Add new hdr image endpoints and hugging face endpoint #57
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Zachary Licastro <[email protected]>
…g face endpoints. Signed-off-by: Zachary Licastro <[email protected]>
fearnworks
reviewed
Sep 26, 2024
|
|
||
|
|
||
| # Helper functions for HDR stats | ||
| def calculate_kurtosis(tensor: torch.Tensor): |
There was a problem hiding this comment.
kurtosis is my vocabulary word for the day
fearnworks
reviewed
Sep 26, 2024
| async def upload_to_huggingface(file: UploadFile = File(...)): | ||
| HF_TOKEN = settings.HF_TOKEN | ||
|
|
||
| if not HF_TOKEN: |
There was a problem hiding this comment.
might be beneficial to add a note somewhere indicating the token needs write permissions
fearnworks
reviewed
Sep 26, 2024
fearnworks
approved these changes
Sep 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves issues #50 , #51 , #52 , and #53
Below are screenshots of trying the endpoints in our OpenAPI setup:
Calculate HDR stats:
Generate JPG Preview:
(Tested copying the resulting data to a base64 online image viewer and the correct image was shown too)
This currently only supports .dng files and could benefit from additional tests of dng files from different devices in the future as well.
Retrieve Image Metadata:
Note, for now, this is intended to fail with GPS data instead of stripping it like the original PoC script. Stripping the data will be done as a future enhancement to avoid making this item bigger and to have something in place for the image upload work in the meantime.
This currently only supports .dng files and could benefit from additional tests of dng files from different devices in the future as well.
Upload to Hugging Face:
As a test of the hugging face endpoint, you can see the resulting upload here (while authenticated): https://huggingface.co/datasets/openmodelinitiative/hdr-submissions/tree/main