-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
44 add dco acceptance #45
Conversation
…uire it. Signed-off-by: Zachary Licastro <[email protected]>
…44-add-dco-acceptance Signed-off-by: Zachary Licastro <[email protected]>
…ts correctly. Signed-off-by: Zachary Licastro <[email protected]>
|
||
|
||
Developer's Certificate of Origin 1.1 | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we cite the "open source license indicated in the file" anywhere in this screen? We might want to clarify that point. If this will be a dataset, I believe its CDLA 2.0
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@hipsterusername No we don't mention the specific license anywhere.
To clarify are you suggesting updating the wording of the DCO here to add a line specifying the license, or should we just have a line above/before the DCO block stating like "The following Developer Certificate of Origin agreement covers all contributions to Open Model Initiative Datasets. All OMI datasets will fall under the CDLA 2.0 license" perhaps with a link to https://cdla.dev/permissive-2-0/ ?
Just wanting to make sure I understand the spec or expected wording updates correctly.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes I think we just need to highlight which license applies in the UI somewhere
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay thanks, I will add the line and link in a quick subsequent PR. 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested :
- Migration
- Register new user
- Login
- DCO Acceptance
- Logout / Relogin
DCO appeared on login, and didn't request again on second login.
LGTM.
Implement #44 by adding DCO acceptance requirement before users can use or contribute to the authenticated website.
Also adds Svelte extension to recommended extensions.