Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add container for api #38

Merged
merged 1 commit into from
Sep 2, 2024
Merged

Add container for api #38

merged 1 commit into from
Sep 2, 2024

Conversation

fearnworks
Copy link
Collaborator

  • Add build image for api
  • Add api and postgres images to a single compose file
  • Update Tasks for the new images

Signed-off-by: jphillips <[email protected]>
Copy link
Collaborator

@CheesyLaZanya CheesyLaZanya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only question I had was that the docker compose file at route now has the postgres and pgadmin services alongside the API, but I don't see the docker compose for the database services (e.g. https://github.com/Open-Model-Initiative/OMI-Data-Pipeline/blob/main/modules/odr_database/docker/postgres-compose.yml) being removed though it looks to just duplicate what's in the root file now.

Is that intended or should that be removed?

Otherwise looks good to me

@fearnworks
Copy link
Collaborator Author

That was left to not break the flows Tom/Robbie might have on their current features. Will remove in the next pass.

@fearnworks fearnworks merged commit 0a592a0 into main Sep 2, 2024
2 checks passed
@fearnworks fearnworks deleted the datamodel_container branch October 6, 2024 15:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants