Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

138 create cdk deployment pipeline #172

Merged
merged 22 commits into from
Feb 22, 2025
Merged

Conversation

Tomislaw
Copy link
Collaborator

@Tomislaw Tomislaw commented Feb 20, 2025

Description

Please include a summary of the changes and the related issue.
Fixes # (issue)

Type of Change

  • Bug fix
  • New feature
  • Documentation update
  • Refactoring
  • CI/CD updates
  • Other (please describe):

How Has This Been Tested?

Describe the tests that you ran to verify your changes. Include details on your testing environment if applicable.

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added or updated tests that prove my fix is effective or my feature works

Additional Context

Add any additional information that might be helpful for the review.

@Tomislaw Tomislaw linked an issue Feb 20, 2025 that may be closed by this pull request
@Tomislaw Tomislaw self-assigned this Feb 20, 2025
@fearnworks
Copy link
Collaborator

Some of the security issues in the sonarcloud medium cat likely need followup issues created (especially around least privilege) , but don't need to hold up this PR to get the action available in the ui.

@fearnworks
Copy link
Collaborator

Can you add something like this to ./doc/deployment/aws_cdk_cicd.rst :

https://gist.github.com/fearnworks/7e9084430cb2a163ecee3b740504a98d#file-aws_cdk_cicd-rst

@Tomislaw Tomislaw force-pushed the 138-create-cdk-deployment-pipeline branch from 217e2cf to eeed01b Compare February 21, 2025 18:11
dependabot bot and others added 19 commits February 21, 2025 19:22
Bumps [vite](https://github.com/vitejs/vite/tree/HEAD/packages/vite) from 5.4.11 to 5.4.12.
- [Release notes](https://github.com/vitejs/vite/releases)
- [Changelog](https://github.com/vitejs/vite/blob/v5.4.12/packages/vite/CHANGELOG.md)
- [Commits](https://github.com/vitejs/vite/commits/v5.4.12/packages/vite)

---
updated-dependencies:
- dependency-name: vite
  dependency-type: direct:development
...

Signed-off-by: dependabot[bot] <[email protected]>
Signed-off-by: Tomislaw <[email protected]>
…igrate operations in a fresh .env.

Signed-off-by: Zachary Licastro <[email protected]>
Signed-off-by: Tomislaw <[email protected]>
Signed-off-by: Tomislaw <[email protected]>
Signed-off-by: Tomislaw <[email protected]>
@Tomislaw Tomislaw force-pushed the 138-create-cdk-deployment-pipeline branch from 7ffa1bb to 851908e Compare February 21, 2025 18:23
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
9 Security Hotspots

See analysis details on SonarQube Cloud

Copy link
Collaborator

@fearnworks fearnworks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

with the updates I think this is good enough for the initial merge. Reviewed the 9 issues and they are fine for now.

Copy link
Collaborator

@CheesyLaZanya CheesyLaZanya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Took a read through of the setup, nothing seemed concerning and I think it's good enough to move forward for now to iterate on once in main.

Did a quick test of the existing local setup and seems to still be working too on this branch.

LGTM.

@fearnworks fearnworks merged commit 15eaed0 into main Feb 22, 2025
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create CDK deployment pipeline
3 participants