-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
138 create cdk deployment pipeline #172
Conversation
Some of the security issues in the sonarcloud medium cat likely need followup issues created (especially around least privilege) , but don't need to hold up this PR to get the action available in the ui. |
Can you add something like this to ./doc/deployment/aws_cdk_cicd.rst : https://gist.github.com/fearnworks/7e9084430cb2a163ecee3b740504a98d#file-aws_cdk_cicd-rst |
217e2cf
to
eeed01b
Compare
Bumps [vite](https://github.com/vitejs/vite/tree/HEAD/packages/vite) from 5.4.11 to 5.4.12. - [Release notes](https://github.com/vitejs/vite/releases) - [Changelog](https://github.com/vitejs/vite/blob/v5.4.12/packages/vite/CHANGELOG.md) - [Commits](https://github.com/vitejs/vite/commits/v5.4.12/packages/vite) --- updated-dependencies: - dependency-name: vite dependency-type: direct:development ... Signed-off-by: dependabot[bot] <[email protected]> Signed-off-by: Tomislaw <[email protected]>
…igrate operations in a fresh .env. Signed-off-by: Zachary Licastro <[email protected]> Signed-off-by: Tomislaw <[email protected]>
Signed-off-by: Tomislaw <[email protected]>
…ues with IAC sub project. Signed-off-by: Tomislaw <[email protected]>
Signed-off-by: Tomislaw <[email protected]>
Signed-off-by: Tomislaw <[email protected]>
Signed-off-by: Tomislaw <[email protected]>
Signed-off-by: Tomislaw <[email protected]>
Signed-off-by: Tomislaw <[email protected]>
…branch for debug purposes. Signed-off-by: Tomislaw <[email protected]>
…ing purposes. Signed-off-by: Tomislaw <[email protected]>
Signed-off-by: Tomislaw <[email protected]>
Signed-off-by: Tomislaw <[email protected]>
…d secrets to ecs_stack.py Signed-off-by: Tomislaw <[email protected]>
…ng configuration. Signed-off-by: Tomislaw <[email protected]>
Signed-off-by: Tomislaw <[email protected]>
Signed-off-by: Tomislaw <[email protected]>
Signed-off-by: Tomislaw <[email protected]>
Signed-off-by: Tomislaw <[email protected]>
7ffa1bb
to
851908e
Compare
…ata-Pipeline into 138-create-cdk-deployment-pipeline
Signed-off-by: Tomislaw <[email protected]>
Signed-off-by: Tomislaw <[email protected]>
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
with the updates I think this is good enough for the initial merge. Reviewed the 9 issues and they are fine for now.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Took a read through of the setup, nothing seemed concerning and I think it's good enough to move forward for now to iterate on once in main.
Did a quick test of the existing local setup and seems to still be working too on this branch.
LGTM.
Description
Please include a summary of the changes and the related issue.
Fixes # (issue)
Type of Change
How Has This Been Tested?
Describe the tests that you ran to verify your changes. Include details on your testing environment if applicable.
Checklist
Additional Context
Add any additional information that might be helpful for the review.