Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Caption Container Optimizations & Qwen Support #118

Merged
merged 5 commits into from
Dec 5, 2024
Merged

Caption Container Optimizations & Qwen Support #118

merged 5 commits into from
Dec 5, 2024

Conversation

fearnworks
Copy link
Collaborator

No description provided.

@fearnworks
Update permissions
8f5bda7 
Signed-off-by: jphillips <[email protected]>
@fearnworks
Add support for Qwen
352d447 
Signed-off-by: jphillips <[email protected]>
@fearnworks fearnworks changed the title Draft : Caption Container optimizations Caption Container Optimizations & Qwen Support Nov 26, 2024
CheesyLaZanya
CheesyLaZanya approved these changes Nov 27, 2024
View reviewed changes
Copy link
Collaborator

@CheesyLaZanya CheesyLaZanya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aside from the Sonarcube security fixes, the PR looks good to me and worked for my testing locally

@fearnworks
Permission updates
78f9108 
Signed-off-by: jphillips <[email protected]>
@fearnworks
chmod to 555
d3c2b76 
Signed-off-by: jphillips <[email protected]>
@fearnworks
Testing hotspot fix
8eddaba 
Signed-off-by: jphillips <[email protected]>
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Dec 5, 2024 •
edited
Loading

Quality Gate Passed Quality Gate passed

Issues
2 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

CheesyLaZanya
CheesyLaZanya approved these changes Dec 5, 2024
View reviewed changes
Copy link
Collaborator

@CheesyLaZanya CheesyLaZanya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed again after security fixes, changes look fine and I was able to generate a caption still. lgtm

@CheesyLaZanya CheesyLaZanya merged commit f4bb0c0 into main Dec 5, 2024
7 checks passed
@CheesyLaZanya CheesyLaZanya deleted the cloud-caption-containers branch December 5, 2024 13:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CheesyLaZanya CheesyLaZanya CheesyLaZanya approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fearnworks @CheesyLaZanya