Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft: build(deps): bump npm from 9.6.7 to 10.5.0 #48

Draft
wants to merge 4 commits into
base: develop
Choose a base branch
from

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Mar 27, 2024

Bumps npm from 9.6.7 to 9.9.3.

Changelog

Sourced from npm's changelog.

9.9.3 (2024-02-26)

Bug Fixes

Dependencies

... (truncated)

Commits

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Copy link
Contributor Author

dependabot bot commented on behalf of github Mar 27, 2024

Dependabot tried to add @Open-Lens/lens-ide as a reviewer to this PR, but received the following error from GitHub:

POST https://api.github.com/repos/Open-Lens/lens/pulls/48/requested_reviewers: 422 - Reviews may only be requested from collaborators. One or more of the teams you specified is not a collaborator of the Open-Lens/lens repository. // See: https://docs.github.com/rest/pulls/review-requests#request-reviewers-for-a-pull-request

Copy link
Collaborator

@gdubcs gdubcs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should go straight for NPM 10.5.0 which is compatible with both Node 18.x and 20.x source

@@ -252,7 +252,7 @@
"moment-timezone": "^0.5.40",
"monaco-editor": "^0.38.0",
"node-pty": "0.10.1",
"npm": "^9.6.7",
"npm": "^9.9.3",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"npm": "^9.9.3",
"npm": "10.5.0",

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍
Should be deeply tested first !

packages/release-tool/package.json Outdated Show resolved Hide resolved
Bumps [npm](https://github.com/npm/cli) from 9.6.7 to 9.9.3.
- [Release notes](https://github.com/npm/cli/releases)
- [Changelog](https://github.com/npm/cli/blob/v9.9.3/CHANGELOG.md)
- [Commits](npm/cli@v9.6.7...v9.9.3)

---
updated-dependencies:
- dependency-name: npm
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot dependabot bot force-pushed the dependabot/npm_and_yarn/npm-9.9.3 branch from 51dc17f to 41350e0 Compare March 28, 2024 15:02
@fbaldo31 fbaldo31 changed the title build(deps): bump npm from 9.6.7 to 9.9.3 Draft: build(deps): bump npm from 9.6.7 to 9.9.3 Mar 29, 2024
@fbaldo31 fbaldo31 force-pushed the dependabot/npm_and_yarn/npm-9.9.3 branch from 92db989 to 5b94bc4 Compare March 29, 2024 06:13
@fbaldo31 fbaldo31 changed the title Draft: build(deps): bump npm from 9.6.7 to 9.9.3 Draft: build(deps): bump npm from 9.6.7 to 10.5.0 Mar 29, 2024
@fbaldo31 fbaldo31 marked this pull request as draft March 29, 2024 07:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants