feat(nodejs): Support Node v18

Open-Lens · Mar 15, 2024 · dc5a6e6 · dc5a6e6
1 parent ba79b29
commit dc5a6e6
Show file tree

Hide file tree

Showing 15 changed files with 19 additions and 18 deletions.
diff --git a/.github/workflows/check-docs.yml b/.github/workflows/check-docs.yml
@@ -10,7 +10,7 @@ jobs:
     if: ${{ contains(github.event.pull_request.labels.*.name, 'area/documentation') }}
     strategy:
       matrix:
-        node-version: [16.x]
+        node-version: [18.x]
     steps:
       - name: Checkout Release from lens
         uses: actions/checkout@v3

diff --git a/.github/workflows/cron-test.yaml b/.github/workflows/cron-test.yaml
@@ -10,7 +10,7 @@ jobs:
       fail-fast: false
       matrix:
         os: [ubuntu-20.04, macos-11, windows-2019]
-        node-version: [16.x]
+        node-version: [18.x]
     steps:
       - name: Checkout Release from lens
         uses: actions/checkout@v3

diff --git a/.github/workflows/daily-alpha.yml b/.github/workflows/daily-alpha.yml
@@ -15,7 +15,7 @@ jobs:
       - name: Setup Node.js
         uses: actions/setup-node@v3
         with:
-          node-version: "16.x"
+          node-version: "18.x"
           registry-url: "https://npm.pkg.github.com"
 
       - name: Install specific npm version

diff --git a/.github/workflows/electronegativity.yml b/.github/workflows/electronegativity.yml
@@ -17,7 +17,7 @@ jobs:
 
       - uses: actions/setup-node@v3
         with:
-          node-version: "16"
+          node-version: "18"
 
       - uses: doyensec/[email protected]
         with:

diff --git a/.github/workflows/linter.yml b/.github/workflows/linter.yml
@@ -10,7 +10,7 @@ jobs:
     runs-on: ubuntu-latest
     strategy:
       matrix:
-        node-version: [16.x]
+        node-version: [18.x]
     steps:
       - name: Checkout Release from lens
         uses: actions/checkout@v3

diff --git a/.github/workflows/mkdocs-manual.yml b/.github/workflows/mkdocs-manual.yml
@@ -11,7 +11,7 @@ jobs:
     runs-on: ubuntu-latest
     strategy:
       matrix:
-        node-version: [16.x]
+        node-version: [18.x]
     steps:
       - name: Set up Python 3.7
         uses: actions/setup-python@v2

diff --git a/.github/workflows/publish-docs.yml b/.github/workflows/publish-docs.yml
@@ -15,7 +15,7 @@ jobs:
     runs-on: ubuntu-latest
     strategy:
       matrix:
-        node-version: [16.x]
+        node-version: [18.x]
     steps:
       - name: Set up Python 3
         uses: actions/setup-python@v2
@@ -52,7 +52,7 @@ jobs:
     runs-on: ubuntu-latest
     strategy:
       matrix:
-        node-version: [16.x]
+        node-version: [18.x]
     needs: verify-docs
     steps:
       - name: Set up Python 3.7

diff --git a/.github/workflows/publish-release-npm.yml b/.github/workflows/publish-release-npm.yml
@@ -17,7 +17,7 @@ jobs:
     runs-on: ubuntu-latest
     strategy:
       matrix:
-        node-version: [16.x]
+        node-version: [18.x]
     steps:
       - name: Checkout Release
         uses: actions/checkout@v3

diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml
@@ -17,7 +17,7 @@ jobs:
       fail-fast: false
       matrix:
         os: [ubuntu-20.04, macos-11, windows-2019]
-        node-version: [16.x]
+        node-version: [18.x]
     steps:
       - name: Checkout Release from lens
         uses: actions/checkout@v3
@@ -90,7 +90,7 @@ jobs:
       fail-fast: false
       matrix:
         os: [ubuntu-20.04]
-        node-version: [16.x]
+        node-version: [18.x]
     steps:
       - name: Checkout Release from lens
         uses: actions/checkout@v3

diff --git a/README.md b/README.md
@@ -29,7 +29,7 @@ Lens Desktop is a standalone application for MacOS, Windows and Linux operating
 
 ### Prequisites
 
-* Nodejs v16
+* Nodejs v16 || v18
 
 ### Install
 

diff --git a/open-lens/package.json b/open-lens/package.json
@@ -43,7 +43,7 @@
     "welcomeRoute": "/welcome"
   },
   "engines": {
-    "node": ">=16 <17"
+    "node": ">=16 <19"
   },
   "jest": {
     "collectCoverage": false,

diff --git a/package-lock.json b/package-lock.json
diff --git a/packages/core/package.json b/packages/core/package.json
@@ -68,7 +68,7 @@
     "welcomeRoute": "/welcome"
   },
   "engines": {
-    "node": ">=16 <17"
+    "node": ">=16 <19"
   },
   "jest": {
     "collectCoverage": false,

diff --git a/packages/core/src/main/__test__/prometheus-handler.test.ts b/packages/core/src/main/__test__/prometheus-handler.test.ts
@@ -186,7 +186,7 @@ describe("PrometheusHandler", () => {
       [2, 2],
       [2, 3],
     ])("should pick the first provider of %d success(es) between %d failure(s)", async (successes, failures) => {
-      const beforeSuccesses = Math.floor(successes / 2);
+      const beforeSuccesses = Math.floor(successes / 4);
 
       runInAction(() => {
         for (let i = 0; i < beforeSuccesses; i += 1) {

diff --git a/packages/core/src/renderer/components/cluster/cluster-issues.tsx b/packages/core/src/renderer/components/cluster/cluster-issues.tsx
@@ -101,10 +101,11 @@ class NonInjectedClusterIssues extends React.Component<ClusterIssuesProps & Depe
     }
 
     const { getId, getName, message, kind, selfLink, renderAge } = warning;
+    const id = getId();
 
     return (
       <TableRow
-        key={getId()}
+        key={id}
         sortItem={warning}
         selected={selfLink === kubeSelectedUrlParam.get()}
         onClick={prevDefault(() => toggleDetails(selfLink))}