Merge pull request #1050 from Open-Earth-Foundation/nina/bug/ON-2864/…

…handleMissingData
Open-Earth-Foundation · Jan 10, 2025 · 40f7009 · 40f7009
2 parents b8ea283 + 831c1ed
commit 40f7009
Show file tree

Hide file tree

Showing 4 changed files with 7 additions and 4 deletions.
diff --git a/app/src/backend/OpenClimateService.ts → app/src/backend/GlobalAPIService.ts b/app/src/backend/OpenClimateService.ts → app/src/backend/GlobalAPIService.ts
@@ -13,6 +13,9 @@ export const getGrowthRatesFromOC = async (
     const response = await fetch(URL);
     logger.info(`${URL} Response Status: ${response.status}`);
     const data = await response.json();
+    if (response.status !== 200) {
+      return undefined;
+    }
     return {
       ...data,
       growthRates: data.growth_rates,

diff --git a/app/src/backend/ResultsService.ts b/app/src/backend/ResultsService.ts
@@ -8,7 +8,7 @@ import { ActivityDataByScope, GroupedActivity } from "@/util/types";
 import Decimal from "decimal.js";
 import { bigIntToDecimal } from "@/util/big_int";
 import createHttpError from "http-errors";
-import { getGrowthRatesFromOC } from "./OpenClimateService";
+import { getGrowthRatesFromOC } from "./GlobalAPIService";
 import { Inventory } from "@/models/Inventory";
 
 function multiplyBigIntByFraction(

diff --git a/app/tests/api/emissions_forecast.jest.ts b/app/tests/api/emissions_forecast.jest.ts
@@ -51,7 +51,7 @@ describe.skip("Emissions Forecast API", () => {
   });
 
   it("should calculate projected emissions correctly", async () => {
-    jest.mock("@/backend/OpenClimateService", () => {
+    jest.mock("@/backend/GlobalAPIService", () => {
       return {
         getGrowthRatesFromOC: jest
           .fn()
@@ -67,7 +67,7 @@ describe.skip("Emissions Forecast API", () => {
   });
 
   it("should handle empty growth factors", async () => {
-    jest.mock("@/backend/OpenClimateService", () => {
+    jest.mock("@/backend/GlobalAPIService", () => {
       return {
         getGrowthRatesFromOC: jest.fn().mockImplementation(() => undefined),
       };

diff --git a/app/tests/api/results.data.ts b/app/tests/api/results.data.ts
@@ -1,5 +1,5 @@
 import { randomUUID } from "node:crypto";
-import { GrowthRatesResponse } from "@/backend/OpenClimateService";
+import { GrowthRatesResponse } from "@/backend/GlobalAPIService";
 
 export const inventoryValueId = randomUUID();
 export const inventoryValueId1 = randomUUID();