Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Introduce StacResource/SaveResult returned from save_result #725

Merged
merged 6 commits into from
Feb 12, 2025
Merged

Introduce StacResource/SaveResult returned from save_result #725

merged 6 commits into from
Feb 12, 2025

Conversation

soxofaan
Copy link
Member

@soxofaan soxofaan commented Feb 7, 2025

soxofaan
soxofaan commented Feb 7, 2025
View reviewed changes
openeo/rest/datacube.py Show resolved Hide resolved
openeo/rest/datacube.py Show resolved Hide resolved
openeo/rest/vectorcube.py Outdated Show resolved Hide resolved
openeo/rest/_datacube.py Outdated Show resolved Hide resolved
openeo/rest/result.py Show resolved Hide resolved
openeo/rest/stac_resource.py Outdated Show resolved Hide resolved
soxofaan
soxofaan commented Feb 10, 2025
View reviewed changes
openeo/rest/stac_resource.py Show resolved Hide resolved
tests/rest/datacube/test_datacube.py Show resolved Hide resolved
tests/rest/datacube/test_datacube100.py Show resolved Hide resolved
tests/rest/datacube/test_vectorcube.py Show resolved Hide resolved
tests/rest/datacube/test_vectorcube.py Show resolved Hide resolved
soxofaan added a commit that referenced this pull request Feb 10, 2025
@soxofaan
Issue #720/#402/#725 re-add tests about create_job/execute_batch with…
d9a032a 
… out_format on a result
soxofaan added a commit that referenced this pull request Feb 10, 2025
@soxofaan
fixup! Issue #720/#402/#725 re-add tests about create_job/execute_bat…
2bd3db4 
…ch with out_format on a result
soxofaan added a commit that referenced this pull request Feb 10, 2025
@soxofaan
fixup! fixup! Issue #720/#402/#725 re-add tests about create_job/exec…
9918275 
…ute_batch with out_format on a result
soxofaan added a commit that referenced this pull request Feb 11, 2025
@soxofaan
Issue #720/#402/#725 add documentation
9d96665
soxofaan added a commit that referenced this pull request Feb 11, 2025
@soxofaan
Synchronize docs between DataCube, VectorCube, ...
62f2221 
use tests to enforce keeping docs in sync

related to #402/#720/#725
soxofaan added a commit that referenced this pull request Feb 11, 2025
@soxofaan
Issue #720/#402/#725 add documentation
3adbcd9
@soxofaan soxofaan force-pushed the issue720-export-workspace-et-al branch from 9d96665 to 3adbcd9 Compare February 11, 2025 21:35
soxofaan added a commit that referenced this pull request Feb 12, 2025
@soxofaan
Synchronize docs between DataCube, VectorCube, ...
2b8f439 
use tests to enforce keeping docs in sync

related to #402/#720/#725
soxofaan added a commit that referenced this pull request Feb 12, 2025
@soxofaan
Synchronize docs between DataCube, VectorCube, ...
f71210b 
use tests to enforce keeping docs in sync

related to #402/#720/#725
soxofaan added a commit that referenced this pull request Feb 12, 2025
@soxofaan
Issue #720/#402/#725 eliminate _ensure_save_result
9eed207
soxofaan added a commit that referenced this pull request Feb 12, 2025
@soxofaan
#720/#402/#725 document SaveResult design background a bit more
12bc236
soxofaan added a commit that referenced this pull request Feb 12, 2025
@soxofaan
fixup! Issue #720/#402/#725 eliminate _ensure_save_result
637c940
@soxofaan soxofaan marked this pull request as ready for review February 12, 2025 15:00
soxofaan
soxofaan commented Feb 12, 2025
View reviewed changes
Copy link
Member Author

@soxofaan soxofaan left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also :

  • add changelog entry

openeo/rest/stac_resource.py Show resolved Hide resolved
This was linked to issues Feb 12, 2025
Add support for export_workspace #720
Closed
DataCube.save_result returns DataCube instead of (wrapped) true #402
Closed
soxofaan added a commit that referenced this pull request Feb 12, 2025
@soxofaan
Issue #720/#402/#725 changelog and more docs
99f419d
soxofaan added a commit that referenced this pull request Feb 12, 2025
@soxofaan
fixup! Issue #720/#402/#725 changelog and more docs
815b73f
soxofaan added a commit that referenced this pull request Feb 12, 2025
@soxofaan
fixup! Issue #720/#402/#725 changelog and more docs
2ff11b9
soxofaan added a commit that referenced this pull request Feb 12, 2025
@soxofaan
Issue #720/#402/#725 re-add tests about create_job/execute_batch with…
94420c4 
… out_format on a result
soxofaan added a commit that referenced this pull request Feb 12, 2025
@soxofaan
Issue #720/#402/#725 add documentation
ac40dbf
soxofaan added a commit that referenced this pull request Feb 12, 2025
@soxofaan
Issue #720/#402/#725 eliminate _ensure_save_result
98ac064
@soxofaan soxofaan force-pushed the issue720-export-workspace-et-al branch from 2ff11b9 to 0f5199a Compare February 12, 2025 15:45
soxofaan added a commit that referenced this pull request Feb 12, 2025
@soxofaan
#720/#402/#725 document SaveResult design background a bit more
d73879c
soxofaan added a commit that referenced this pull request Feb 12, 2025
@soxofaan
Issue #720/#402/#725 changelog and more docs
0f5199a
@soxofaan soxofaan force-pushed the issue720-export-workspace-et-al branch from 0f5199a to 42ed8df Compare February 12, 2025 15:47
soxofaan added a commit that referenced this pull request Feb 12, 2025
@soxofaan
#720/#402/#725 document SaveResult design background a bit more
cc57804
soxofaan added a commit that referenced this pull request Feb 12, 2025
@soxofaan
Issue #720/#402/#725 changelog and more docs
42ed8df
@soxofaan soxofaan force-pushed the issue720-export-workspace-et-al branch from 42ed8df to be0fd37 Compare February 12, 2025 15:47
@soxofaan soxofaan merged commit 0fa49c3 into master Feb 12, 2025
8 checks passed
@soxofaan soxofaan deleted the issue720-export-workspace-et-al branch February 12, 2025 15:55
@soxofaan soxofaan self-assigned this Feb 12, 2025
soxofaan added a commit that referenced this pull request Feb 12, 2025
@soxofaan
Synchronize docs between DataCube, VectorCube, ...
6b68329 
use tests to enforce keeping docs in sync

related to #402/#720/#725
@soxofaan soxofaan mentioned this pull request Feb 12, 2025
Draft
soxofaan added a commit that referenced this pull request Feb 13, 2025
@soxofaan
Synchronize docs between DataCube, VectorCube, ...
1cd9b1d 
use tests to enforce keeping docs in sync

related to #402/#720/#725
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@soxofaan soxofaan

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add support for export_workspace DataCube.save_result returns DataCube instead of (wrapped) true
1 participant
@soxofaan