Skip to content

Commit

Permalink
Fix cum* process descriptions and make ignore_nodata descriptions ali…
Browse files Browse the repository at this point in the history
…gn better with the other reducers #522
  • Loading branch information
m-mohr committed Nov 22, 2024
1 parent 3744511 commit 0390558
Show file tree
Hide file tree
Showing 5 changed files with 9 additions and 8 deletions.
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
- `aggregate_temporal` and `aggregate_temporal_period`: Clarified that the process throws a `DimensionNotAvailable` exception when no temporal dimension exists.
- `aggregate_temporal_period`: Removed unused exception `DistinctDimensionLabelsRequired`
- `aggregate_temporal_period`: Clarified that the definition of weeks follows ISO 8601
- `cummax`, `cummin`, `cumproduct`, `cumsum`: Clarified the descriptions around the `ignore_nodata` parameter.
- `divide`: Clarified behavior for division by 0
- `between`: Clarify that `null` is passed through.
- `eq` and `neq`: Explicitly set the minimum value for the `delta` parameter.
Expand Down
4 changes: 2 additions & 2 deletions proposals/cummax.json
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
{
"id": "cummax",
"summary": "Cumulative maxima",
"description": "Finds cumulative maxima of an array of numbers. Every computed element is equal to the bigger one between the current element and the previously computed element. The returned array and the input array have always the same length.\n\nBy default, no-data values are skipped, but stay in the result. Setting the `ignore_nodata` flag to `true` makes that once a no-data value (`null`) is reached all following elements are set to `null` in the result.",
"description": "Finds cumulative maxima of an array of numbers. Every computed element is equal to the bigger one between the current element and the previously computed element. The returned array and the input array have always the same length.\n\nBy default, no-data values are skipped, but stay in the result. Setting the `ignore_nodata` flag to `false` makes that once a no-data value (`null`) is reached all following elements are set to `null` in the result.",
"categories": [
"math > cumulative"
],
Expand All @@ -22,7 +22,7 @@
},
{
"name": "ignore_nodata",
"description": "Indicates whether no-data values are ignored or not and ignores them by default. Setting this flag to `false` considers no-data values so that `null` is set for all the following elements.",
"description": "Indicates whether no-data values are ignored or not. Ignores them by default. Setting this flag to `false` considers no-data values so that `null` is set for all the following elements.",
"schema": {
"type": "boolean"
},
Expand Down
4 changes: 2 additions & 2 deletions proposals/cummin.json
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
{
"id": "cummin",
"summary": "Cumulative minima",
"description": "Finds cumulative minima of an array of numbers. Every computed element is equal to the smaller one between the current element and the previously computed element. The returned array and the input array have always the same length.\n\nBy default, no-data values are skipped, but stay in the result. Setting the `ignore_nodata` flag to `true` makes that once a no-data value (`null`) is reached all following elements are set to `null` in the result.",
"description": "Finds cumulative minima of an array of numbers. Every computed element is equal to the smaller one between the current element and the previously computed element. The returned array and the input array have always the same length.\n\nBy default, no-data values are skipped, but stay in the result. Setting the `ignore_nodata` flag to `false` makes that once a no-data value (`null`) is reached all following elements are set to `null` in the result.",
"categories": [
"math > cumulative"
],
Expand All @@ -22,7 +22,7 @@
},
{
"name": "ignore_nodata",
"description": "Indicates whether no-data values are ignored or not and ignores them by default. Setting this flag to `false` considers no-data values so that `null` is set for all the following elements.",
"description": "Indicates whether no-data values are ignored or not. Ignores them by default. Setting this flag to `false` considers no-data values so that `null` is set for all the following elements.",
"schema": {
"type": "boolean"
},
Expand Down
4 changes: 2 additions & 2 deletions proposals/cumproduct.json
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
{
"id": "cumproduct",
"summary": "Cumulative products",
"description": "Computes cumulative products of an array of numbers. Every computed element is equal to the product of the current and all previous values. The returned array and the input array have always the same length.\n\nBy default, no-data values are skipped, but stay in the result. Setting the `ignore_nodata` flag to `true` makes that once a no-data value (`null`) is reached all following elements are set to `null` in the result.",
"description": "Computes cumulative products of an array of numbers. Every computed element is equal to the product of the current and all previous values. The returned array and the input array have always the same length.\n\nBy default, no-data values are skipped, but stay in the result. Setting the `ignore_nodata` flag to `false` makes that once a no-data value (`null`) is reached all following elements are set to `null` in the result.",
"categories": [
"math > cumulative"
],
Expand All @@ -22,7 +22,7 @@
},
{
"name": "ignore_nodata",
"description": "Indicates whether no-data values are ignored or not and ignores them by default. Setting this flag to `false` considers no-data values so that `null` is set for all the following elements.",
"description": "Indicates whether no-data values are ignored or not. Ignores them by default. Setting this flag to `false` considers no-data values so that `null` is set for all the following elements.",
"schema": {
"type": "boolean"
},
Expand Down
4 changes: 2 additions & 2 deletions proposals/cumsum.json
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
{
"id": "cumsum",
"summary": "Cumulative sums",
"description": "Computes cumulative sums of an array of numbers. Every computed element is equal to the sum of current and all previous values. The returned array and the input array have always the same length.\n\nBy default, no-data values are skipped, but stay in the result. Setting the `ignore_nodata` flag to `true` makes that once a no-data value (`null`) is reached all following elements are set to `null` in the result.",
"description": "Computes cumulative sums of an array of numbers. Every computed element is equal to the sum of current and all previous values. The returned array and the input array have always the same length.\n\nBy default, no-data values are skipped, but stay in the result. Setting the `ignore_nodata` flag to `false` makes that once a no-data value (`null`) is reached all following elements are set to `null` in the result.",
"categories": [
"math > cumulative"
],
Expand All @@ -22,7 +22,7 @@
},
{
"name": "ignore_nodata",
"description": "Indicates whether no-data values are ignored or not and ignores them by default. Setting this flag to `false` considers no-data values so that `null` is set for all the following elements.",
"description": "Indicates whether no-data values are ignored or not. Ignores them by default. Setting this flag to `false` considers no-data values so that `null` is set for all the following elements.",
"schema": {
"type": "boolean"
},
Expand Down

0 comments on commit 0390558

Please sign in to comment.