Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#80 drop python 2 support #81

Merged
merged 2 commits into from
Dec 21, 2021
Merged

#80 drop python 2 support #81

merged 2 commits into from
Dec 21, 2021

Conversation

vancamti
Copy link
Contributor

@vancamti vancamti commented Dec 13, 2021 •
edited
Loading

@Wim-De-Clercq can you review this one?

@coveralls
Copy link

coveralls commented Dec 13, 2021 •
edited
Loading

Coverage Status

Coverage increased (+0.03%) to 99.44% when pulling 206c31e on vancamti:feature/80_drop_python_2_support into 2289525 on koenedaele:develop.

Wim-De-Clercq
Wim-De-Clercq reviewed Dec 17, 2021
View reviewed changes
tests/test_utils.py Outdated
os.path.join(os.path.dirname(__file__), 'data', 'menu.csv'),
"r"
)
os.path.join(os.path.dirname(__file__), 'data', 'menu.csv'))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mss nog op 1 lijn hier.

@koenedaele koenedaele merged commit be41452 into OnroerendErfgoed:develop Dec 21, 2021
koenedaele added a commit that referenced this pull request Dec 21, 2021
@koenedaele
Merge branch 'develop' of github.com:koenedaele/skosprovider_sqlalche…
b65c189 
…my into develop

* 'develop' of github.com:koenedaele/skosprovider_sqlalchemy:
  #80 drop python 2 support (#81)
  #78 upgrade requirements (#82)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Wim-De-Clercq Wim-De-Clercq Wim-De-Clercq approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@vancamti @coveralls @Wim-De-Clercq @koenedaele