Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make cs optional for import. Refs #100 #101

Merged
merged 2 commits into from
Mar 30, 2023

Conversation

koenedaele
Copy link
Member

No description provided.

@coveralls
Copy link

coveralls commented Mar 29, 2023

Coverage Status

Coverage: 99.281% (+0.01%) from 99.266% when pulling a2c4c3e on feature/100_conceptscheme_optional into ccfa585 on develop.

@coveralls
Copy link

Coverage Status

Coverage: 99.283% (+0.02%) from 99.266% when pulling 2a0b7cf on feature/100_conceptscheme_optional into ccfa585 on develop.

@koenedaele
Copy link
Member Author

@Wim-De-Clercq I've had to change the method signature to make the ConceptScheme optional, so this would a BC breaking change. I don't think there's a good way of avoiding that?

Copy link
Contributor

@Wim-De-Clercq Wim-De-Clercq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see a good way of keeping it BC, the only way would be to have a function with a new name and keep the old one.

fyi, Python does have some "overloading" capabilities. BUT they call it 'dispatching' and in the standard library it only works on the first argument https://docs.python.org/3/library/functools.html#functools.singledispatch

Of course we could download a third party library which works on more arguments, but that starts to feel like overkill.

@koenedaele koenedaele merged commit 6bbfc38 into develop Mar 30, 2023
@koenedaele koenedaele deleted the feature/100_conceptscheme_optional branch March 30, 2023 13:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants