Tsystems 211 upgrade spring boot #707
Conversation
…d not keycloak authentication token
There was a problem hiding this comment.
hey @tkuzynow, added some comments, and for now I did not had a look at the tests, is that ok?
| <phase>process-sources</phase> | ||
| <configuration> | ||
| <target> | ||
| <delete file="${project.build.directory}/generated-sources/de/caritas/cob/userservice/api/adapters/web/dto/GroupSessionConsultantDTO.java"/> |
There was a problem hiding this comment.
oh for what is this needed?
There was a problem hiding this comment.
I encountered some issues with file access when running tests after upgrade and this fixed it
There was a problem hiding this comment.
ok, got it. but this is quite unhandy for the future :( no change to get rid of this?
There was a problem hiding this comment.
I don't have another solution, without the change we're getitng errors like this on compile:
src/main/java/de/caritas/cob/userservice/api/admin/service/admin/search/AdminFilterService.java
Outdated
Show resolved
Hide resolved
| import org.springframework.data.annotation.CreatedDate; | ||
| import org.springframework.data.annotation.LastModifiedDate; | ||
| import org.springframework.data.jpa.domain.support.AuditingEntityListener; | ||
|
|
||
| /** Represents a user */ | ||
| @Entity | ||
| @Table(name = "user") | ||
| @Table(name = "`user`") |
There was a problem hiding this comment.
yes :) it was a fix for tests in H2.
But unfortunately this did not help for MariaDB, so eventually I needed to update the table name to _USER, as user is the reserved keyword in MariaDB, Hibernate in new version threw various exceptions when the table was named user or USER.
There was a problem hiding this comment.
wanted always to ask for what is the reserved keyword, but now you say it, for MariaDB.
To be honest, I have no better idea than your rename suggestion :/
| @@ -0,0 +1,10 @@ | |||
| @FilterDefs({ | |||
There was a problem hiding this comment.
oh this is ähm nice ;) so you can define that in the package-info that it matches for all classes inside?
There was a problem hiding this comment.
there was a tenantFilter defined in all entity classes, now we need to define this on package level, which for tenantFilter is actually a benefit :)
There was a problem hiding this comment.
is this a must? interesting, then it would not be possible to have a filter only for dedicated classes.
There was a problem hiding this comment.
I think the problem was with repetition of filterDef in the context for multiple entities, so you can still configure it per entity but you cannot repeat same filter definition
… which prevents login of consultants
… which prevents login of consultants
… which prevents login of consultants
… which prevents login of consultants
… which prevents login of consultants
… which prevents login of consultants
… which prevents login of consultants
…h prevents loading of messages
…hich prevents loading of messages
|
Fixes #
Proposed Changes