Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: improved extension logic to be able to import original file in … #996

Merged
merged 1 commit into from
Feb 12, 2024

Conversation

web-mi
Copy link
Contributor

@web-mi web-mi commented Jan 27, 2024

…extension

Fixes #

Proposed Changes

Copy link

what-the-diff bot commented Jan 27, 2024

PR Summary

  • Update to Configuration File Handling
    Modifications have been made to our project's configuration file. This involves updating how we decide if a file should be superseded. Moreover, we've implemented logs to notify us when a file is set to be overridden or when something tries to reference itself which improves our ability to troubleshoot.

  • Introduction of New Dependencies
    We've included two new dependencies in our project: html-react-parser and html-dom-parser . These give us more options when parsing HTML in our React application, providing us with more flexibility and control.

  • Changes in Launch Scripts and Configurations
    Updates made in our 'package.json' file further support these changes. We've updated our development server launch script and added a new configuration section for 'nodemon', an utility that will help us by automatically restarting the application when file changes are detected in the development environment.

@web-mi web-mi force-pushed the OB-Theming branch 6 times, most recently from 0e0ebe4 to 70e711a Compare February 4, 2024 16:44
@web-mi web-mi marked this pull request as ready for review February 5, 2024 02:02
Copy link
Contributor

@janrembold janrembold left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was ein MR!!! 🚀 Bin nur grob drüber gegangen, ist einfach zu viel um überall ins Deetail zu gehen. Mir sind nur ein paar Kleinigkeiten ins Auge gesprungen. Schau's dir mal an...

pnboliveira
pnboliveira previously approved these changes Feb 12, 2024
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link
Member

@patric-dosch-vi patric-dosch-vi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved after rebase

@web-mi web-mi requested a review from janrembold February 12, 2024 14:04
@web-mi web-mi merged commit c75a6da into develop Feb 12, 2024
8 checks passed
@web-mi web-mi deleted the OB-Theming branch February 12, 2024 14:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants