Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: fix urls without domain #987

Merged
merged 1 commit into from
Jan 16, 2024
Merged

fix: fix urls without domain #987

merged 1 commit into from
Jan 16, 2024

Conversation

web-mi
Copy link
Contributor

@web-mi web-mi commented Jan 16, 2024

Fixes #

Proposed Changes

@what-the-diff What The Diff
Copy link

what-the-diff bot commented Jan 16, 2024

PR Summary

  • Enhancement in getUrl function within LegalLinksProvider.tsx
    The getUrl function is now designed to ensure that all URLs used are absolute. This means that if any URL used in the system is not complete (i.e., not an absolute URL), the function will automatically add the necessary starting part from the current website's address. This can reduce the chance of incorrect or broken links, thereby improving the user's experience.

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

The SonarCloud Quality Gate passed, but some issues were introduced.

1 New issue
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@web-mi web-mi merged commit 4cea5c2 into develop Jan 16, 2024
7 checks passed
@web-mi web-mi deleted the OB-5604 branch January 16, 2024 09:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@janrembold janrembold janrembold approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@web-mi @janrembold