Add random sorting method to QueryHelper and apply it in Monitor prob…

…e fetching
OneUptime · Nov 26, 2024 · b10134f · b10134f
1 parent 93027ec
commit b10134f
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 2 deletions.
diff --git a/Common/Server/Types/Database/QueryHelper.ts b/Common/Server/Types/Database/QueryHelper.ts
@@ -8,6 +8,13 @@ import { FindOperator, Raw } from "typeorm";
 import { FindWhereProperty } from "../../../Types/BaseDatabase/Query";
 
 export default class QueryHelper {
+
+  public static sortByRandom(): FindWhereProperty<any> {
+    return Raw(() => {
+      return "RANDOM()";
+    });
+  }
+
   public static findWithSameText(
     text: string | number,
   ): FindWhereProperty<any> {

diff --git a/ProbeIngest/API/Monitor.ts b/ProbeIngest/API/Monitor.ts
@@ -340,8 +340,8 @@ router.post(
         await MonitorProbeService.findBy({
           query: getMonitorFetchQuery((req as OneUptimeRequest).probe!.id!),
           sort: {
-            nextPingAt: SortOrder.Ascending,
-          },
+            nextPingAt: QueryHelper.sortByRandom(), // randomize the order of the monitors
+          } as any,
           skip: 0,
           limit: limit,
           select: {