Skip to content

Commit

Permalink
feat: enhance SlackIntegration component with connection handlers and…
Browse files Browse the repository at this point in the history
… improve notification rule naming
  • Loading branch information
simlarsen committed Feb 7, 2025
1 parent 311f7db commit 8e1d6b4
Show file tree
Hide file tree
Showing 3 changed files with 6 additions and 3 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -317,6 +317,8 @@ const ServiceProviderNotificationRuleTable: FunctionComponent<
projectId: DashboardNavigation.getProjectId()!,
eventType: props.eventType,
}}
singularName={`${props.eventType} Notification Rule`}
pluralName={`${props.eventType} Notification Rules`}
id="servie-provider-table"
name="Settings > Service Provider Notification Rules"
isDeleteable={true}
Expand Down
2 changes: 0 additions & 2 deletions Dashboard/src/Components/Slack/SlackIntegration.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -53,8 +53,6 @@ const SlackIntegration: FunctionComponent<ComponentProps> = (props: ComponentPro
setIsProjectAccountConnected,
] = React.useState<boolean>(false);
const [isButtonLoading, setIsButtonLoading] = React.useState<boolean>(false);



useEffect(() => {
if(isProjectAccountConnected){
Expand Down
5 changes: 4 additions & 1 deletion Dashboard/src/Pages/UserSettings/SlackIntegration.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,10 @@ import React, { FunctionComponent, ReactElement } from "react";
import SlackIntegration from "../../Components/Slack/SlackIntegration";

const Settings: FunctionComponent<PageComponentProps> = (): ReactElement => {
return <SlackIntegration />;
return <SlackIntegration
onConnected={()=>{}}
onDisconnected={()=>{}}
/>;
};

export default Settings;

0 comments on commit 8e1d6b4

Please sign in to comment.