Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce language methods on user model #143

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

ElwynVdb
Copy link

@ElwynVdb ElwynVdb commented Apr 25, 2024

Overview

This pull request builds upon the functionalities introduced in a previous PR submitted to the web-SDK, which added language functions. It aims to provide access to these newly introduced functions directly from the front-end SDK.

Benefits

  • Set the language in the front-end when you don't want to work based of the browser language.

Related pull requests

@ElwynVdb
Copy link
Author

@sherwinski I have seen the following PR on the web SDK has been released: OneSignal/OneSignal-Website-SDK#1171

The changes from this pull request implement the SDK changes. Would be cool if this can be follow on the release of the new features :)

@sherwinski
Copy link
Contributor

Hey @ElwynVdb, thanks for bringing this to my attention. Unfortunately, this project is code-generated from https://github.com/OneSignal/web-shim-codegen so I'm not able to accept outside contributions without them being overwritten. The good news is that the Language functions are already staged for this SDK's next release, which I hope to publish next week. Hope that helps!

@sherwinski sherwinski mentioned this pull request Jan 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants