-
Notifications
You must be signed in to change notification settings - Fork 377
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Merge pull request #1648 from OneSignal/user_model_rebase
Merge major_release_5.0.0 into main
- Loading branch information
Showing
65 changed files
with
4,064 additions
and
10,899 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,60 +1,75 @@ | ||
| <!-- START --> | ||
|
|
||
| # READ AND DELETE THIS SECTION BEFORE SUBMITTING PR | ||
| * **Fill out each _REQUIRED_ section** | ||
| * **Fill out _OPTIONAL_ sections, remove section if it doesn't apply to your PR** | ||
| * **Read and fill out each of the checklists below** | ||
| * **Remove this section after reading** | ||
|
|
||
| - **Fill out each _REQUIRED_ section** | ||
| - **Fill out _OPTIONAL_ sections, remove section if it doesn't apply to your PR** | ||
| - **Read and fill out each of the checklists below** | ||
| - **Remove this section after reading** | ||
| <!-- END --> | ||
|
|
||
| # Description | ||
|
|
||
| ## One Line Summary | ||
|
|
||
| **REQUIRED** - Very short description that summaries the changes in this PR. | ||
|
|
||
| ## Details | ||
|
|
||
| ### Motivation | ||
|
|
||
| **REQUIRED -** Why is this code change being made? Or what is the goal of this PR? Examples: Fixes a specific bug, provides additional logging to debug future issues, feature to allow X. | ||
|
|
||
| ### Scope | ||
|
|
||
| **RECOMMEND - OPTIONAL -** What is intended to be effected. What is known not to change. Example: Notifications are grouped when parameter X is set, not enabled by default. | ||
|
|
||
| ### OPTIONAL - Other | ||
|
|
||
| **OPTIONAL -** Feel free to add any other sections or sub-sections that can explain your PR better. | ||
|
|
||
| # Testing | ||
|
|
||
| ## Unit testing | ||
| **OPTIONAL -** Explain unit tests added, if not clear in the code. | ||
|
|
||
| **OPTIONAL -** Explain unit tests added, if not clear in the code. | ||
|
|
||
| ## Manual testing | ||
|
|
||
| **RECOMMEND - OPTIONAL -** Explain what scenarios were tested and the environment. | ||
| Example: Tested opening a notification while the app was foregrounded, app build with Android Studio 2020.3 with a fresh install of the OneSignal example app on a Pixel 6 with Android 12. | ||
|
|
||
| # Affected code checklist | ||
| - [ ] Notifications | ||
| - [ ] Display | ||
| - [ ] Open | ||
| - [ ] Push Processing | ||
| - [ ] Confirm Deliveries | ||
| - [ ] Outcomes | ||
| - [ ] Sessions | ||
| - [ ] In-App Messaging | ||
| - [ ] REST API requests | ||
| - [ ] Public API changes | ||
|
|
||
| - [ ] Notifications | ||
| - [ ] Display | ||
| - [ ] Open | ||
| - [ ] Push Processing | ||
| - [ ] Confirm Deliveries | ||
| - [ ] Outcomes | ||
| - [ ] Sessions | ||
| - [ ] In-App Messaging | ||
| - [ ] REST API requests | ||
| - [ ] Public API changes | ||
|
|
||
| # Checklist | ||
|
|
||
| ## Overview | ||
| - [ ] I have filled out all **REQUIRED** sections above | ||
| - [ ] PR does one thing | ||
| - If it is hard to explain how any codes changes are related to each other then it most likely needs to be more than one PR | ||
| - [ ] Any Public API changes are explained in the PR details and conform to existing APIs | ||
|
|
||
| - [ ] I have filled out all **REQUIRED** sections above | ||
| - [ ] PR does one thing | ||
| - If it is hard to explain how any codes changes are related to each other then it most likely needs to be more than one PR | ||
| - [ ] Any Public API changes are explained in the PR details and conform to existing APIs | ||
|
|
||
| ## Testing | ||
| - [ ] I have included test coverage for these changes, or explained why they are not needed | ||
| - [ ] All automated tests pass, or I explained why that is not possible | ||
| - [ ] I have personally tested this on my device, or explained why that is not possible | ||
|
|
||
| - [ ] I have included test coverage for these changes, or explained why they are not needed | ||
| - [ ] All automated tests pass, or I explained why that is not possible | ||
| - [ ] I have personally tested this on my device, or explained why that is not possible | ||
|
|
||
| ## Final pass | ||
| - [ ] Code is as readable as possible. | ||
| - Simplify with less code, followed by splitting up code into well named functions and variables, followed by adding comments to the code. | ||
| - [ ] I have reviewed this PR myself, ensuring it meets each checklist item | ||
| - WIP (Work In Progress) is ok, but explain what is still in progress and what you would like feedback on. Start the PR title with "WIP" to indicate this. | ||
|
|
||
| - [ ] Code is as readable as possible. | ||
| - Simplify with less code, followed by splitting up code into well named functions and variables, followed by adding comments to the code. | ||
| - [ ] I have reviewed this PR myself, ensuring it meets each checklist item | ||
| - WIP (Work In Progress) is ok, but explain what is still in progress and what you would like feedback on. Start the PR title with "WIP" to indicate this. |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,82 @@ | ||
| # For most projects, this workflow file will not need changing; you simply need | ||
| # to commit it to your repository. | ||
| # | ||
| # You may wish to alter this file to override the set of languages analyzed, | ||
| # or to provide custom queries or build logic. | ||
| # | ||
| # ******** NOTE ******** | ||
| # We have attempted to detect the languages in your repository. Please check | ||
| # the `language` matrix defined below to confirm you have the correct set of | ||
| # supported CodeQL languages. | ||
| # | ||
| name: "CodeQL" | ||
|
|
||
| on: | ||
| push: | ||
| branches: [ "main", "major_release_5.0.0" ] | ||
| pull_request: | ||
| # The branches below must be a subset of the branches above | ||
| branches: [ "main", "major_release_5.0.0" ] | ||
| schedule: | ||
| - cron: '37 19 * * 4' | ||
|
|
||
| jobs: | ||
| analyze: | ||
| name: Analyze | ||
| # Runner size impacts CodeQL analysis time. To learn more, please see: | ||
| # - https://gh.io/recommended-hardware-resources-for-running-codeql | ||
| # - https://gh.io/supported-runners-and-hardware-resources | ||
| # - https://gh.io/using-larger-runners | ||
| # Consider using larger runners for possible analysis time improvements. | ||
| runs-on: ${{ (matrix.language == 'swift' && 'macos-latest') || 'ubuntu-latest' }} | ||
| timeout-minutes: ${{ (matrix.language == 'swift' && 120) || 360 }} | ||
| permissions: | ||
| actions: read | ||
| contents: read | ||
| security-events: write | ||
|
|
||
| strategy: | ||
| fail-fast: false | ||
| matrix: | ||
| language: [ 'javascript-typescript' ] | ||
| # CodeQL supports [ 'c-cpp', 'csharp', 'go', 'java-kotlin', 'javascript-typescript', 'python', 'ruby', 'swift' ] | ||
| # Use only 'java-kotlin' to analyze code written in Java, Kotlin or both | ||
| # Use only 'javascript-typescript' to analyze code written in JavaScript, TypeScript or both | ||
| # Learn more about CodeQL language support at https://aka.ms/codeql-docs/language-support | ||
|
|
||
| steps: | ||
| - name: Checkout repository | ||
| uses: actions/checkout@v3 | ||
|
|
||
| # Initializes the CodeQL tools for scanning. | ||
| - name: Initialize CodeQL | ||
| uses: github/codeql-action/init@v2 | ||
| with: | ||
| languages: ${{ matrix.language }} | ||
| # If you wish to specify custom queries, you can do so here or in a config file. | ||
| # By default, queries listed here will override any specified in a config file. | ||
| # Prefix the list here with "+" to use these queries and those in the config file. | ||
|
|
||
| # For more details on CodeQL's query packs, refer to: https://docs.github.com/en/code-security/code-scanning/automatically-scanning-your-code-for-vulnerabilities-and-errors/configuring-code-scanning#using-queries-in-ql-packs | ||
| # queries: security-extended,security-and-quality | ||
|
|
||
|
|
||
| # Autobuild attempts to build any compiled languages (C/C++, C#, Go, Java, or Swift). | ||
| # If this step fails, then you should remove it and run the build manually (see below) | ||
| - name: Autobuild | ||
| uses: github/codeql-action/autobuild@v2 | ||
|
|
||
| # ℹ️ Command-line programs to run using the OS shell. | ||
| # 📚 See https://docs.github.com/en/actions/using-workflows/workflow-syntax-for-github-actions#jobsjob_idstepsrun | ||
|
|
||
| # If the Autobuild fails above, remove it and uncomment the following three lines. | ||
| # modify them (or add more) to build your code if your project, please refer to the EXAMPLE below for guidance. | ||
|
|
||
| # - run: | | ||
| # echo "Run, Build Application using script" | ||
| # ./location_of_script_within_repo/buildscript.sh | ||
|
|
||
| - name: Perform CodeQL Analysis | ||
| uses: github/codeql-action/analyze@v2 | ||
| with: | ||
| category: "/language:${{matrix.language}}" |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,18 @@ | ||
| name: NPM Publish | ||
|
|
||
| on: | ||
| release: | ||
| types: [created] | ||
|
|
||
| jobs: | ||
| publish: | ||
| runs-on: ubuntu-latest | ||
| steps: | ||
| - uses: actions/checkout@v3 | ||
| - uses: actions/setup-node@v3 | ||
| with: | ||
| node-version: 18 | ||
| - name: Publish package | ||
| uses: JS-DevTools/npm-publish@v1 | ||
| with: | ||
| token: ${{ secrets.NPM }} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,4 +1,3 @@ | ||
|
|
||
| name: Release Drafter | ||
|
|
||
| on: | ||
|
|
||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.