Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix NewPlayer function arguments #23

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

mochizuki-pg
Copy link

@mochizuki-pg mochizuki-pg commented Feb 12, 2023

Description

NewPlayer function arguments in the latest package documentation are different from the GitHub repository.
https://pkg.go.dev/github.com/OneSignal/[email protected]?utm_source=gopls#NewPlayer

Also, if you don't explicitly pass the AppId to the structure,
internal API processing, an error will occur that app_id is not found.

Details

Motivation

REQUIRED - Why is this code change being made? Or what is the goal of this PR? Examples: Fixes a specific bug, provides additional logging to debug future issues, feature to allow X.

Scope

RECOMMEND - OPTIONAL - What is intended to be effected. What is known not to change. Example: Notifications are grouped when parameter X is set, not enabled by default.

OPTIONAL - Other

OPTIONAL - Feel free to add any other sections or sub-sections that can explain your PR better.

Testing

Manual testing

Before

DefaultApi.CreatePlayer`: 400 Bad Request
"errors":["app_id not found. You may be missing a Content-Type: application/json header."]

After

スクリーンショット 2023-02-12 18 42 17

Checklist

Overview

  • I have filled out all REQUIRED sections above
  • PR does one thing
    • If it is hard to explain how any codes changes are related to each other then it most likely needs to be more than one PR
  • Any Public API changes are explained in the PR details and conform to existing APIs

Testing

  • I have personally tested this on my device, or explained why that is not possible

Final pass

  • Code is as readable as possible.
    • Simplify with less code, followed by splitting up code into well named functions and variables, followed by adding comments to the code.
  • I have reviewed this PR myself, ensuring it meets each checklist item
    • WIP (Work In Progress) is ok, but explain what is still in progress and what you would like feedback on. Start the PR title with "WIP" to indicate this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant