Removing duplicate checks for set_external_user_id #917
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This check has caused issues with the external id not being set after setting email, and this check is not on Android. Removing to match Android behavior and avoid potential issues.
Now that setExternalUserId's put request is called after registerUser the unit tests need to be updated.
jkasten2
approved these changes
Apr 23, 2021
There was a problem hiding this comment.
Reviewed 2 of 2 files at r1.
Reviewable status: 2 of 3 files reviewed, all discussions resolved (waiting on @Jeasmine)
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have seen some issues where set_external_user_id is not being set on channel records with an error that it has already been set. This PR simplifies the set_external_user_id code to always set the external user id, even if it matches the cached value for that channel. This will make setExternalUserId more reliable and simplifies the code path.
This change is