Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[cd] update xcode version to 15.2 #1433

Merged
merged 1 commit into from
May 11, 2024
Merged

[cd] update xcode version to 15.2 #1433

merged 1 commit into from
May 11, 2024

Conversation

nan-li
Copy link
Contributor

@nan-li nan-li commented May 10, 2024

Description

One Line Summary

Update our CD script to use xcode 15.2, necessary to build now with Live Activities and xcode 15 being the minimum.

Details

Motivation

Release 5.2.0 CD failed then passed after these changes

The CI is already using 15.2.

Scope

CD

Testing

Unit testing

Manual testing

Affected code checklist

  • Notifications
    • Display
    • Open
    • Push Processing
    • Confirm Deliveries
  • Outcomes
  • Sessions
  • In-App Messaging
  • REST API requests
  • Public API changes

Checklist

Overview

  • I have filled out all REQUIRED sections above
  • PR does one thing
  • Any Public API changes are explained in the PR details and conform to existing APIs

Testing

  • I have included test coverage for these changes, or explained why they are not needed
  • All automated tests pass, or I explained why that is not possible
  • I have personally tested this on my device, or explained why that is not possible

Final pass

  • Code is as readable as possible.
  • I have reviewed this PR myself, ensuring it meets each checklist item

This change is Reviewable

@nan-li nan-li requested a review from emawby May 10, 2024 22:34
@nan-li nan-li merged commit 504f41f into main May 11, 2024
4 checks passed
@nan-li nan-li deleted the cd/update_xcode_version branch May 11, 2024 00:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants