Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CD] code sign release binaries #1401

Merged
merged 1 commit into from
Apr 23, 2024
Merged

[CD] code sign release binaries #1401

merged 1 commit into from
Apr 23, 2024

Conversation

emawby
Copy link
Contributor

@emawby emawby commented Apr 9, 2024

Description

One Line Summary

Adding code signing to the binaries in the CD step

Details

We are now code signing using a OneSignal Inc Distribution certificate in our CD after building the binaries with a Lilomi Dev certificate.

These certs will needed to be updated in Github yearly.

Motivation

Apple code signing

Scope

cd

Testing

Unit testing

N/A

Manual testing

tested the workflow by adding a on pr: step

Affected code checklist

  • Notifications
    • Display
    • Open
    • Push Processing
    • Confirm Deliveries
  • Outcomes
  • Sessions
  • In-App Messaging
  • REST API requests
  • Public API changes

Checklist

Overview

  • I have filled out all REQUIRED sections above
  • PR does one thing
    • If it is hard to explain how any codes changes are related to each other then it most likely needs to be more than one PR
  • Any Public API changes are explained in the PR details and conform to existing APIs

Testing

  • I have included test coverage for these changes, or explained why they are not needed
  • All automated tests pass, or I explained why that is not possible
  • I have personally tested this on my device, or explained why that is not possible

Final pass

  • Code is as readable as possible.
    • Simplify with less code, followed by splitting up code into well named functions and variables, followed by adding comments to the code.
  • I have reviewed this PR myself, ensuring it meets each checklist item
    • WIP (Work In Progress) is ok, but explain what is still in progress and what you would like feedback on. Start the PR title with "WIP" to indicate this.

This change is Reviewable

@emawby emawby changed the title [WiP] code sign release binaries [CD] code sign release binaries Apr 10, 2024
@emawby emawby force-pushed the test_code_signing branch from 2d48dc0 to c00bb89 Compare April 10, 2024 00:37
@emawby emawby requested review from nan-li and jkasten2 April 10, 2024 00:37
@emawby emawby force-pushed the test_code_signing branch from c00bb89 to 72c3d88 Compare April 10, 2024 00:40
@nan-li nan-li changed the base branch from main to fix_cd April 12, 2024 18:51
@nan-li nan-li changed the base branch from fix_cd to main April 12, 2024 18:52
@nan-li
Copy link
Contributor

nan-li commented Apr 12, 2024

Needs changes from #1378
We can test the next release with that PR + this one.

@nan-li nan-li force-pushed the test_code_signing branch from 72c3d88 to 1c6736f Compare April 15, 2024 22:16
Copy link
Contributor

@nan-li nan-li left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Used this to release v5.1.5

@emawby emawby merged commit 2fe6e89 into main Apr 23, 2024
4 checks passed
@emawby emawby deleted the test_code_signing branch April 23, 2024 18:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants