Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
One Line Summary
Fix
swiftlint
errors so that our linting and CI can succeed.Details
1. Ran
swiftlint --fix
commit2. Organize User module files commit
Executors
and move executor files into this folderOSUserExecutor
class into its own file, removed from theOSUserRequests
mega-fileRequests
and move request-related files to this folderOSUserRequests
mega-file into its own fileOSUserRequest.swift
will contain just the protocol and an extension of OneSignalRequest3. Organize
OSUserExecutor
functionality with a class extension commitOSUserExecutor
into an extension of the class.swiftlint.yml
file to override thetype_body_length
rule to accept a longer length.Motivation
Part of making our CI succeed as well as actually utilizing our linter.
Scope
Testing
Unit testing
None
Manual testing
None, ensure SDK builds and app runs after changes.
Affected code checklist
Checklist
Overview
Testing
Final pass
This change is![Reviewable](https://camo.githubusercontent.com/1541c4039185914e83657d3683ec25920c672c6c5c7ab4240ee7bff601adec0b/68747470733a2f2f72657669657761626c652e696f2f7265766965775f627574746f6e2e737667)