WIP unit test merge taking a look #1347
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Had some errors
- that changed after API changed
* Commenting out any file that was failing in some way * Opt to comment out instead of deleting files.
nan-li
force-pushed
the
5.0.0/unit_tests_merge
branch
from
2228ed7 to
68cf664
Compare
* Motivation: encountered error with "Include of non-modular header inside framework module OneSignalCore" and crashing on start with "Library not loaded OneSignalOSCore"... * Update the following build configurations that were different between Debug & Release and Test - Skip Install - Test - changed from NO to YES - Strip Debug Symbols During Copy - Test - changed from YES to NO - Targeted Device Families - Test - iPhone to iPhone and iPad - Compatibility Version - Test - set to 1 - Current Library Version - Test - set to 1 - Dynamic Library Install Name Base - Test - changed to rpath - Runpath Search Paths - Test - updated to match - Use Compiler to Extract Swift Strings - Test - changed to YES - Defines Module - Test - changed to YES - Generate Info.plist File - Test - changed to YES to match Release and Debug - enable modules - Test - set to YES
Sets `UnitTestApp` and `UnitTests` targets to have min deployment to 11
- `OneSignalLiveActivityController.m` added to UnitTests target membership - Adds missing `OneSignalLocation.framework` and `OneSignalInAppMessages.framework` and `OneSignalNotifications.framework` to UnitTests target "Frameworks and Libraries". Split out after modularization..
nan-li
force-pushed
the
5.0.0/unit_tests_merge
branch
from
636feb8 to
bf01202
Compare
- UNUserNotificationCenterOverrider was causing a crash
nan-li
force-pushed
the
5.0.0/unit_tests_merge
branch
from
d1981bb to
ae44997
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
One Line Summary
REQUIRED - Very short description that summaries the changes in this PR.
Details
Motivation
REQUIRED - Why is this code change being made? Or what is the goal of this PR? Examples: Fixes a specific bug, provides additional logging to debug future issues, feature to allow X.
Scope
RECOMMEND - OPTIONAL - What is intended to be effected. What is known not to change. Example: Notifications are grouped when parameter X is set, not enabled by default.
OPTIONAL - Other
OPTIONAL - Feel free to add any other sections or sub-sections that can explain your PR better.
Testing
Unit testing
OPTIONAL - Explain unit tests added, if not clear in the code.
Manual testing
RECOMMEND - OPTIONAL - Explain what scenarios were tested and the environment.
Example: Tested opening a notification while the app was foregrounded, app build with Android Studio 2020.3 with a fresh install of the OneSignal example app on a Pixel 6 with Android 12.
Affected code checklist
Checklist
Overview
Testing
Final pass
This change is