Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
One Line Summary
Add public
OneSignal.User.getTags()
method to return local tags for the current user.Details
getTags
public method that will return local tags for the current usergetTags
method used for IAM processing by appending the internal keyword. I chose not to combine these two methods as one may be called without privacy consent while the public one should be guarded for privacy consent.Motivation
We removed the
getTags
method in v5 of the iOS SDK to discourage use of OneSignal tags as a data store. We have heard feedback from app developers that they have a need for this method still, so we are adding back an implementation to return the local tags.Scope
Keep note it returns the local tags and not via a server fetch so any tags added mid-session through the REST API will not be reflected.
Testing
Unit testing
None
Manual testing
iPhone 13 on iOS 17.1.1 that the following scenarios behave appropriately
Affected code checklist
Checklist
Overview
Testing
Final pass
This change is