Skip to content

Commit

Permalink
2.8.2 Release
Browse files Browse the repository at this point in the history
* Adds a new badge handling system in the OneSignalNotificationServiceExtension
* The SDK now handles badge count logic on the device itself instead of relying on the backend
* Adds support for the NSLocationAlwaysAndWhenInUseUsageDescription Info.plist location permissions key
  • Loading branch information
Nightsd01 committed Mar 23, 2018
1 parent 1e9a365 commit be5ca2a
Show file tree
Hide file tree
Showing 5 changed files with 4 additions and 5 deletions.
2 changes: 1 addition & 1 deletion OneSignal.podspec
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
Pod::Spec.new do |s|
s.name = "OneSignal"
s.version = "2.8.1"
s.version = "2.8.2"
s.summary = "OneSignal push notification library for mobile apps."
s.homepage = "https://onesignal.com"
s.license = { :type => 'MIT', :file => 'LICENSE' }
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -122,6 +122,7 @@ typedef NS_ENUM(NSUInteger, OSNotificationDisplayType) {

/* The badge assigned to the application icon */
@property(readonly)NSUInteger badge;
@property(readonly)NSInteger badgeIncrement;

/* The sound parameter passed to the notification
By default set to UILocalNotificationDefaultSoundName */
Expand Down
Binary file not shown.
2 changes: 1 addition & 1 deletion iOS_SDK/OneSignalSDK/Source/OneSignal.m
Original file line number Diff line number Diff line change
Expand Up @@ -131,7 +131,7 @@ @implementation OSPendingCallbacks

@implementation OneSignal

NSString* const ONESIGNAL_VERSION = @"020801";
NSString* const ONESIGNAL_VERSION = @"020802";
static NSString* mSDKType = @"native";
static BOOL coldStartFromTapOnNotification = NO;

Expand Down
4 changes: 1 addition & 3 deletions iOS_SDK/OneSignalSDK/UnitTests/EmailTests.m
Original file line number Diff line number Diff line change
Expand Up @@ -143,7 +143,7 @@ - (void)testUnauthenticatedEmail {
[OneSignal setEmail:@"[email protected]" withSuccess:nil withFailure:nil];

[UnitTestCommonMethods runBackgroundThreads];
NSLog(@"LAST REQ: %@", OneSignalClientOverrider.lastHTTPRequest);

//check to make sure the OSRequestCreateDevice HTTP call was made, and was formatted correctly
XCTAssertTrue([NSStringFromClass([OSRequestUpdateDeviceToken class]) isEqualToString:OneSignalClientOverrider.lastHTTPRequestType]);
XCTAssertEqual(OneSignalClientOverrider.lastHTTPRequest[@"app_id"], @"b2f7f966-d8cc-11e4-bed1-df8f05be55ba");
Expand All @@ -165,8 +165,6 @@ - (void)testUnauthenticatedEmail {

[UnitTestCommonMethods runBackgroundThreads];

NSLog(@"LAST HTTP TYPE: %@", OneSignalClientOverrider.lastHTTPRequestType);
NSLog(@"LAST HTTP REQ: %@", OneSignalClientOverrider.lastHTTPRequest);
//check to make sure the server gets updated with the new email
XCTAssertTrue([NSStringFromClass([OSRequestUpdateDeviceToken class]) isEqualToString:OneSignalClientOverrider.lastHTTPRequestType]);
XCTAssertEqual(OneSignalClientOverrider.lastHTTPRequest[@"app_id"], @"b2f7f966-d8cc-11e4-bed1-df8f05be55ba");
Expand Down

0 comments on commit be5ca2a

Please sign in to comment.