Skip to content

Commit

Permalink
update setLanguage method
Browse files Browse the repository at this point in the history
* Don't allow setting language to nil (language param is not optional)
* Don't let setting language to ""
  • Loading branch information
nan-li committed Jan 30, 2023
1 parent 85e56f7 commit 2e2ec42
Showing 1 changed file with 8 additions and 2 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,7 @@ import OneSignalNotifications
func addSmsNumber(_ number: String)
func removeSmsNumber(_ number: String) -> Bool
// Language
func setLanguage(_ language: String?) // TODO: why optional? As a remove?
func setLanguage(_ language: String)
// JWT Token Expire
typealias OSJwtCompletionBlock = (_ newJwtToken: String) -> Void
typealias OSJwtExpiredHandler = (_ externalId: String, _ completion: OSJwtCompletionBlock) -> Void
Expand Down Expand Up @@ -646,10 +646,16 @@ extension OneSignalUserManagerImpl: OSUser {
return self.subscriptionModelStore.remove(number)
}

public func setLanguage(_ language: String?) {
public func setLanguage(_ language: String) {
guard !OneSignalConfigManager.shouldAwaitAppIdAndLogMissingPrivacyConsent(forMethod: "setLanguage") else {
return
}

if language == "" {
OneSignalLog.onesignalLog(.LL_ERROR, message: "OneSignal.User.setLanguage cannot be called with an empty language code.")
return
}

user.setLanguage(language)
}
}
Expand Down

0 comments on commit 2e2ec42

Please sign in to comment.