Skip to content

Commit

Permalink
iOS_SDK: add one more constructor to just take appId and launchOptions
Browse files Browse the repository at this point in the history
Xamarin does some strict enforcement for parameters at runtime.
It was agreed that there needs to be a constructor that just takes
the OneSignal application id and launch options, but not the notification
handler callback.
  • Loading branch information
Vivek Ayer committed Feb 13, 2016
1 parent 285168f commit 08c2b5d
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 0 deletions.
2 changes: 2 additions & 0 deletions iOS_SDK/OneSignal/OneSignal.h
Original file line number Diff line number Diff line change
Expand Up @@ -61,6 +61,8 @@ typedef NS_ENUM(NSUInteger, ONE_S_LOG_LEVEL) {

- (id)initWithLaunchOptions:(NSDictionary*)launchOptions autoRegister:(BOOL)autoRegister;

- (id)initWithLaunchOptions:(NSDictionary*)launchOptions appId:(NSString*)appId;

- (id)initWithLaunchOptions:(NSDictionary*)launchOptions handleNotification:(OneSignalHandleNotificationBlock)callback;

- (id)initWithLaunchOptions:(NSDictionary*)launchOptions appId:(NSString*)appId handleNotification:(OneSignalHandleNotificationBlock)callback;
Expand Down
4 changes: 4 additions & 0 deletions iOS_SDK/OneSignal/OneSignal.m
Original file line number Diff line number Diff line change
Expand Up @@ -102,6 +102,10 @@ - (id)initWithLaunchOptions:(NSDictionary*)launchOptions autoRegister:(BOOL)auto
return [self initWithLaunchOptions:launchOptions appId:nil handleNotification:nil autoRegister:autoRegister];
}

- (id)initWithLaunchOptions:(NSDictionary*)launchOptions appId:(NSString*)appId {
return [self initWithLaunchOptions:launchOptions appId:appId handleNotification:nil autoRegister:true];
}

- (id)initWithLaunchOptions:(NSDictionary*)launchOptions handleNotification:(OneSignalHandleNotificationBlock)callback {
return [self initWithLaunchOptions:launchOptions appId:nil handleNotification:callback autoRegister:true];
}
Expand Down

0 comments on commit 08c2b5d

Please sign in to comment.