Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update indexed-db tests #1219

Merged
merged 1 commit into from
Jan 30, 2025
Merged

update indexed-db tests #1219

merged 1 commit into from
Jan 30, 2025

Conversation

fadi-george
Copy link
Contributor

@fadi-george fadi-george commented Jan 29, 2025

Description

1 Line Summary

Slightly improve test coverage of the IndexedDB service and create a db operation helper.

Details

  • removes unnecessary/deprecated node-sass since we already use sass package
  • moves indexedDB tests next to the file it tests
  • sets coverage information in the jest config
  • update typings for LimitStore
  • adds new public objectStoreNames method for IndexedDB class to help with testing
  • adds new dbOperation method for IdnexedDB class to keep code more dry for certain operations like put, get, getAll, etc.

Systems Affected

  • WebSDK
  • Backend
  • Dashboard

Validation

Tests

Info

Checklist

  • All the automated tests pass or I explained why that is not possible
  • I have personally tested this on my machine or explained why that is not possible
  • I have included test coverage for these changes or explained why they are not needed

Programming Checklist
Interfaces:

  • Don't use default export
  • New interfaces are in model files

Functions:

  • Don't use default export
  • All function signatures have return types
  • Helpers should not access any data but rather be given the data to operate on.

Typescript:

  • No Typescript warnings
  • Avoid silencing null/undefined warnings with the exclamation point

Other:

  • Iteration: refrain from using elem of array syntax. Prefer forEach or use map
  • Avoid using global OneSignal accessor for context if possible. Instead, we can pass it to function/constructor so that we don't call OneSignal.context

Screenshots

Info

=============================== Coverage summary ===============================
Statements   : 39.4% ( 2947/7479 )
Branches     : 25.4% ( 919/3617 )
Functions    : 33.33% ( 463/1389 )
Lines        : 39.64% ( 2918/7360 )
================================================================================
Test Suites: 24 passed, 24 total
Tests:       135 passed, 135 total
Snapshots:   0 total
Time:        4.891 s

Checklist

  • I have included screenshots/recordings of the intended results or explained why they are not needed

Related Tickets



This change is Reviewable

@fadi-george fadi-george merged commit 97d6811 into main Jan 30, 2025
4 checks passed
@fadi-george fadi-george deleted the fg/update-tests branch January 30, 2025 22:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants