-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Fix] OneSignalConfig.androidlib minSdkVersion and targetSdkVersion for Unity 2021 #675
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jinliu9508
approved these changes
Jan 17, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Confirmed that the change works in Unity and Android.
In Unity 2021.3.10, "defaultConfig.minSdk" produces the Android build error: Could not get unknown property. This error does not occur in Unity 2022.3.10. Since both Unity versions can successfully build with "defaultConfig.minSdkVersion.mApiLevel" , this change was made.
Deleted OneSignalConfig.androidlib from example project and ran Window > OneSignal SDK Setup > Copy Android plugin to Assets to apply changes made in previous commit to the example app
c3f2dee
to
3e1d04e
Compare
jinliu9508
pushed a commit
that referenced
this pull request
Feb 23, 2024
[Fix] OneSignalConfig.androidlib minSdkVersion and targetSdkVersion for Unity 2021
jinliu9508
pushed a commit
that referenced
this pull request
Feb 27, 2024
[Fix] OneSignalConfig.androidlib minSdkVersion and targetSdkVersion for Unity 2021
jinliu9508
pushed a commit
that referenced
this pull request
Feb 27, 2024
[Fix] OneSignalConfig.androidlib minSdkVersion and targetSdkVersion for Unity 2021
jinliu9508
pushed a commit
that referenced
this pull request
Feb 27, 2024
[Fix] OneSignalConfig.androidlib minSdkVersion and targetSdkVersion for Unity 2021
jinliu9508
pushed a commit
that referenced
this pull request
Feb 27, 2024
[Fix] OneSignalConfig.androidlib minSdkVersion and targetSdkVersion for Unity 2021
jinliu9508
pushed a commit
that referenced
this pull request
Mar 1, 2024
[Fix] OneSignalConfig.androidlib minSdkVersion and targetSdkVersion for Unity 2021
jinliu9508
pushed a commit
that referenced
this pull request
Mar 4, 2024
[Fix] OneSignalConfig.androidlib minSdkVersion and targetSdkVersion for Unity 2021
jinliu9508
pushed a commit
that referenced
this pull request
Mar 4, 2024
[Fix] OneSignalConfig.androidlib minSdkVersion and targetSdkVersion for Unity 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
One Line Summary
Fixes OneSignalConfig.androidlib minSdkVersion and targetSdkVersion Android build errors in Unity 2021
Details
Motivation
Fixes the following Android build error in Unity 2021.3.10 that occurs when calling
defaultConfig.minSdk
and similarly fordefaultConfig.targetSdk
. This error does not occur in Unity 2022.3.10.Both Unity versions successfully build when using
defaultConfig.minSdkVersion.mApiLevel
anddefaultConfig.minSdkVersion.mApiLevel
Scope
In the next release, devs need to apply the changes made to OneSignalConfig.androidlib:
Testing
Manual testing
Tested building for Android on a new Unity project (3D Core template) with the OneSignal SDK installed with Unity 2021.3.10f1 and 2022.3.10f1. Also tested building for Android with the OneSignal example app on Unity 2022.3.10f1.
Affected code checklist
Checklist
Overview
Testing
Final pass
This change is![Reviewable](https://camo.githubusercontent.com/1541c4039185914e83657d3683ec25920c672c6c5c7ab4240ee7bff601adec0b/68747470733a2f2f72657669657761626c652e696f2f7265766965775f627574746f6e2e737667)