Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ci] update actions to v4 #2250

Merged
merged 1 commit into from
Jan 31, 2025
Merged

[ci] update actions to v4 #2250

merged 1 commit into from
Jan 31, 2025

Conversation

nan-li
Copy link
Contributor

@nan-li nan-li commented Jan 30, 2025

Description

Upgrade actions for CI due to deprecation.

Details

  • Let's update all actions packages to v4. It looks like there is no other changes needed after bumping the version, as we have little additional configurations.
  • The android-actions/setup-android is still on release v3 so keep the same

Motivation

Motivated by CI breaking, seen in the failure of this PR run
Also: See deprecation notice: https://github.blog/changelog/2024-04-16-deprecation-notice-v3-of-the-artifact-actions/

Scope

CI

Testing

CI now success: https://github.com/OneSignal/OneSignal-Android-SDK/actions/runs/13062566604/job/36448678877?pr=2250

Affected code checklist

  • Notifications
    • Display
    • Open
    • Push Processing
    • Confirm Deliveries
  • Outcomes
  • Sessions
  • In-App Messaging
  • REST API requests
  • Public API changes

Checklist

Overview

  • I have filled out all REQUIRED sections above
  • PR does one thing
  • Any Public API changes are explained in the PR details and conform to existing APIs

Testing

  • I have included test coverage for these changes, or explained why they are not needed
  • All automated tests pass, or I explained why that is not possible
  • I have personally tested this on my device, or explained why that is not possible

Final pass

  • Code is as readable as possible.
  • I have reviewed this PR myself, ensuring it meets each checklist item

This change is Reviewable

* See deprecation notice: https://github.blog/changelog/2024-04-16-deprecation-notice-v3-of-the-artifact-actions/
* Let's update all `actions` packages to v4
* The `android-actions/setup-android` is still on release v3
@nan-li nan-li requested review from jkasten2 and jinliu9508 January 31, 2025 01:43
@nan-li nan-li merged commit 9cf7cd0 into main Jan 31, 2025
4 checks passed
@nan-li nan-li deleted the ci_upgrade_actions_deprecation branch January 31, 2025 21:49
@jinliu9508 jinliu9508 mentioned this pull request Feb 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants