[Player Model] Fix project errors #1934
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In Android Studio 2022.3.1 it seems Kotlin 1.4 is no longer supported the following error is shown when attempting to build: java.lang.NoClassDefFoundError: Could not initialize class org.jetbrains.kotlin.com.intellij.pom.java.LanguageLevel
We bumped to a new FCM version which requires a min SDK version of 19, it seems we only missed this in the tests.
jkasten2
changed the title
nan-li
approved these changes
Dec 7, 2023
Base automatically changed from
player-model/fix-notification-permission-compile-error
to
main
December 7, 2023 02:23
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
One Line Summary
Fix build errors the prevent building with Android Studio 2022.3.1 and running the tests at all.
Details
minSdkVersion: 19in tests (from 17).Motivation
We want to allow building with modern Android Studio versions and we want to test to run again to prevent silently missing bugs.
Scope
Only fixing project building and test building issues in Player Model (v4).
Testing
Unit testing
Manual testing
I am able to build and run on Android Studio 2022.3.1 on Windows 11 23H2 with an Android 14 emulator after these fixes.
Affected code checklist
Checklist
Overview
Testing
Final pass
This change is