Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Player Model] Fix notification permission compile error #1933

Merged
merged 3 commits into from
Dec 7, 2023
Merged

[Player Model] Fix notification permission compile error #1933

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
69b959f
removed extra equals to correct invalid syntax
jkasten2 Dec 6, 2023
54131de
rm unneeded ChecksSdkIntAtLeast
jkasten2 Dec 6, 2023
cc437c8
make supportsNativePrompt private
jkasten2 Dec 6, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions OneSignalSDK/onesignal/src/main/java/com/onesignal/NotificationPermissionController.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,6 @@
package com.onesignal

import android.os.Build
import androidx.annotation.ChecksSdkIntAtLeast

object NotificationPermissionController : PermissionsActivity.PermissionCallback {
private const val PERMISSION_TYPE = "NOTIFICATION"
Expand All @@ -42,8 +41,7 @@ object NotificationPermissionController : PermissionsActivity.PermissionCallback
PermissionsActivity.registerAsCallback(PERMISSION_TYPE, this)
}

@ChecksSdkIntAtLeast(api = 33)
val supportsNativePrompt: Boolean by lazy = {
private val supportsNativePrompt: Boolean by lazy {
Build.VERSION.SDK_INT > 32 &&
OSUtils.getTargetSdkVersion(OneSignal.appContext) > 32
}
Expand Down
Loading