Merge pull request #872 from OneSignal/fix_flaky_waiting_of_threads_i…

…n_tests Add a 2nd run of runOSThreads if first didn't find
OneSignal · Oct 22, 2019 · bf091c8 · bf091c8
2 parents 5099bcb + 5da1fdc
commit bf091c8
Showing 1 changed file with 2 additions and 1 deletion.
diff --git a/OneSignalSDK/unittest/src/test/java/com/test/onesignal/TestHelpers.java b/OneSignalSDK/unittest/src/test/java/com/test/onesignal/TestHelpers.java
@@ -173,7 +173,8 @@ static void threadAndTaskWait() throws Exception {
 
       boolean createdNewThread;
       do {
-         createdNewThread = runOSThreads();
+         // We run a 2nd time if we did not find any threads to ensure we don't skip any
+         createdNewThread = runOSThreads() || runOSThreads();
 
          boolean advancedRunnables = OneSignalPackagePrivateHelper.runAllNetworkRunnables();
          advancedRunnables = OneSignalPackagePrivateHelper.runFocusRunnables() || advancedRunnables;