Skip to content

Commit

Permalink
Add Trims trailing whitespace in pre-commit-hooks (pyvista#4211)
Browse files Browse the repository at this point in the history
* Add Trims trailing whitespace in pre-commit-hooks

* Update airplane.ply

* Update hexbeam.vtk

* Update rectilinear.vtk

* Update .pre-commit-config.yaml
  • Loading branch information
tkoyama010 authored Apr 3, 2023
1 parent a73b153 commit 1f28aad
Show file tree
Hide file tree
Showing 15 changed files with 23 additions and 21 deletions.
2 changes: 1 addition & 1 deletion .devcontainer/devcontainer.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"image": "mcr.microsoft.com/devcontainers/python:3.11",
"features": {
"features": {
"ghcr.io/devcontainers/features/desktop-lite:1": {},
"ghcr.io/devcontainers/features/github-cli:1": {}
},
Expand Down
8 changes: 4 additions & 4 deletions .github/ISSUE_TEMPLATE/bug-report.yml
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
name: Bug Report
description: Create a report to help us fix broken features
labels: ["bug"]
body:
body:
- type: markdown
attributes:
value: |
Expand All @@ -16,7 +16,7 @@ body:
placeholder: Tell us what you see!
value: "I found a bug!"
validations:
required: true
required: true
- type: textarea
id: reproduce
attributes:
Expand All @@ -41,11 +41,11 @@ body:
import pyvista as pv
print(pv.Report())
```
render: shell
render: shell
validations:
required: true
- type: textarea
id: screenshots
attributes:
label: Screenshots
description: If applicable, please add screenshots to the text box below
description: If applicable, please add screenshots to the text box below
2 changes: 1 addition & 1 deletion .github/ISSUE_TEMPLATE/feature-request.yml
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
name: Feature Request
description: Request that a feature be added to PyVista
labels: ["feature-request"]
body:
body:
- type: markdown
attributes:
value: |
Expand Down
2 changes: 1 addition & 1 deletion .github/ISSUE_TEMPLATE/maintenance-request.yml
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
name: Maintenance Request
description: Request general maintenance to code, CI, deployment, or otherwise
labels: ["maintenance"]
body:
body:
- type: markdown
attributes:
value: |
Expand Down
2 changes: 1 addition & 1 deletion .github/PULL_REQUEST_TEMPLATE.md
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@

<!-- Please insert a high-level description of this pull request here. -->

<!-- Be sure to link other PRs or issues that relate to this PR here. -->
<!-- Be sure to link other PRs or issues that relate to this PR here. -->

<!-- If this fully addresses an issue, please use the keyword `resolves` in front of that issue number. -->

Expand Down
2 changes: 2 additions & 0 deletions .pre-commit-config.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -80,6 +80,8 @@ repos:
- id: no-commit-to-branch
args: [--branch, main]
- id: requirements-txt-fixer
- id: trailing-whitespace
exclude: ^(|pyvista/examples/.*\.ply|pyvista/examples/.*\.vtk)

# this validates our github workflow files
- repo: https://github.com/python-jsonschema/check-jsonschema
Expand Down
2 changes: 1 addition & 1 deletion CITATION.cff
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ preferred-citation:
orcid: "https://orcid.org/0000-0002-8232-7212"
doi: "10.21105/joss.01450"
journal: "Journal of Open Source Software"
publisher:
publisher:
name: "The Open Journal"
month: May
title: "PyVista: 3D plotting and mesh analysis through a streamlined interface for the Visualization Toolkit (VTK)"
Expand Down
2 changes: 1 addition & 1 deletion doc/source/api/core/composite.rst
Original file line number Diff line number Diff line change
Expand Up @@ -83,7 +83,7 @@ Dictionary-like Features


``MultiBlock`` also has some dictionary features. We can set the name
of the blocks, and then access them
of the blocks, and then access them

.. jupyter-execute::

Expand Down
2 changes: 1 addition & 1 deletion doc/source/api/examples/index.rst
Original file line number Diff line number Diff line change
Expand Up @@ -118,7 +118,7 @@ cell types.
.. autosummary::
:toctree: _autosummary

plot_cell
plot_cell
Empty
Vertex
PolyVertex
Expand Down
4 changes: 2 additions & 2 deletions doc/source/api/index.rst
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@ Highlights of the API include:
structures.

.. jupyter-execute::

>>> import pyvista as pv
>>> mesh = pv.Cube()
>>> pl = pv.Plotter()
Expand All @@ -68,7 +68,7 @@ Highlights of the API include:
>>> from pyvista import examples
>>> reader = pv.get_reader(examples.hexbeamfile)
>>> reader


.. card:: Utilities
:link: utilities-api-index
Expand Down
4 changes: 2 additions & 2 deletions doc/source/user-guide/data_model.rst
Original file line number Diff line number Diff line change
Expand Up @@ -281,9 +281,9 @@ in the same order as we defined earlier.
as many (or as few as one) points per cell as we wish.

.. note::
All cell types follow the same connectivity array format:
All cell types follow the same connectivity array format:

``[Number of points, Point 1, Point 2, ...]``
``[Number of points, Point 1, Point 2, ...]``


Except for ``polyhedron`` type, in which we need to define each face of the cell. The
Expand Down
2 changes: 1 addition & 1 deletion examples/02-plot/README.rst
Original file line number Diff line number Diff line change
Expand Up @@ -14,4 +14,4 @@ plotting routines to perform tasks like:
* Creating side-by-side comparisons
* Making a dataset transparent or using a scalar value to map opacity
* Adding textures/images draped over a mesh (texture mapping)
* Rendering a depth image
* Rendering a depth image
6 changes: 3 additions & 3 deletions examples_flask/dynamic_ex/templates/index.html
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@
<option>Vectors</option>
<option disabled="true" value="divider">-------------</option>
<option>Queen Nefertiti</option>

</select>

<div class="item">
Expand Down Expand Up @@ -53,15 +53,15 @@
<iframe src="" height="600" width="600" title="PyVista" id="myimg" frameBorder="0" allowtransparency=yes scrolling=no>
<p>Your browser does not support iframes.</p>
</iframe>

</body>
<script>
$(document).ready(function() {
$('#retrieve').click(function(){
$.ajax({
url: "{{ url_for ('get_img') }}",
type: "GET",
data: {
data: {
meshtype: $('#meshtype option:selected').val(),
show_edges: ($("#show_edges").is(":checked")),
lighting: ($("#lighting").is(":checked")),
Expand Down
2 changes: 1 addition & 1 deletion examples_flask/static_ex/templates/index.html
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@
$.ajax({
url: "{{ url_for ('get_img') }}",
type: "GET",
data: {
data: {
meshtype: $('#meshtype option:selected').val()
},
success: function(response) {
Expand Down
2 changes: 1 addition & 1 deletion tests/tinypages/some_plots.rst
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ Plot 4 defines ``a`` in a context block:
a = 10
import pyvista
pyvista.Plane().plot()


Plot 5 shows that a block with context sees the new variable. It also uses
``:nofigs:``:
Expand Down

0 comments on commit 1f28aad

Please sign in to comment.