Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Thank you for the very nice library @OmkarPathak . This PR adds the minimum changes to make string parsing work for
pyresparse
. For example one can now do the following :However, given that the string has to be properly formatted (see the test here) I don't know how useful that is in its current form (like the use mentioned in #45). In my case, I already had an excel file that I imported to a dataframe which I used to read the strings row by row. I then parsed them with
pyresparse
to extract what I needed from each paragraph (each row in my case).Even though the function added just returns the input, the test written makes sure it works as intended in case it needs any additional changes. Lastly, the
test_name.py
file was changed totest_pyresparser.py
and moved to atest
folder. Thetest_local_name.py
test was failing due to a problem with the format of the pdf file. I changed it to test the extracted skills instead of the name. I hope that makes sense.