-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
stm32f103_rey6: implement std periph driver #26
stm32f103_rey6: implement std periph driver #26
Conversation
Needs rebase. |
rebased and updated to newest version in RIOT-OS/RIOT#614 |
@@ -1,8 +1,8 @@ | |||
#ifndef HWTIMER_CPU_H_ | |||
#define HWTIMER_CPU_H_ | |||
|
|||
#define HWTIMER_MAXTIMERS 4 | |||
#define HWTIMER_SPEED 2000 | |||
#define ARCH_MAXTIMERS 4 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
use HWTIMER_MAXTIMERS instead of ARCH_MAXTIMERS
I get
and so on. |
I updated RIOT-OS/thirdparty_board#18 to be consistent with this PR an fix the |
updated addressing |
MODULE = periph | ||
|
||
# include RIOTs generic Makefile | ||
include $(MAKEBASE)/Makefile.base |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Use RIOTBASE
Now I get repeated
|
This you get because the timer driver interface was changed, an |
updated handling |
Is this in a working condition? |
yes it is |
@haukepetersen can you please review this? |
@haukepetersen any comments or may I squash? |
#define HWTIMER_MAXTICKS (0xFFFF) | ||
#define HWTIMER_MAXTIMERS (4) | ||
#define HWTIMER_SPEED (2303U) | ||
#define HWTIMER_MAXTICKS (0xFFFF) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How about a consistent indention?!
Ok, just these 2 minor remarks. I do not have an STMf10x board here - so I trust you that it is working. If you'd address these two things I give an ACK. |
updated addressing @haukepetersen's comments and adopted to renaming from |
ACK |
squashed and GO |
stm32f103_rey6: implement std periph driver
Implement peripheral driver for timer introduced by @haukepetersen
needs accompanying PR OlegHahm/thirdparty_boards#18 to work