use MessageRunMode struct #2779
Open
+172
−202
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cla-bot
bot
added
the
s
magicxyyz
commented
Nov 15, 2024
| @@ -1424,7 +1406,7 @@ func Create2ndNodeWithConfig( | |||
| Require(t, err) | |||
| wasmData, err := chainStack.OpenDatabaseWithExtraOptions("wasm", 0, 0, "wasm/", false, conf.PersistentConfigDefault.Pebble.ExtraOptions("wasm")) | |||
| Require(t, err) | |||
| chainDb := rawdb.WrapDatabaseWithWasm(chainData, wasmData, wasmCacheTag, execConfig.StylusTarget.WasmTargets()) | |||
| chainDb := rawdb.WrapDatabaseWithWasm(chainData, wasmData) | |||
There was a problem hiding this comment.
as now the wasm tag is coupled with MessageRunContext: are we ok with the all tests running with wasm long term cache enabled?
There was a problem hiding this comment.
The problem with tests using long-term cache is that multiple tests run in parallel, and in prallel with other tests initializing static vars etc. It's.. probably o.k. as long as the tests that do target long-term cache are not run in parallel with anything else.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves NIT-2827
Pulls OffchainLabs/go-ethereum#373