Improve precompile counting test #2742
Open
+11
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
PlasmaPower
commented
Oct 17, 2024
PlasmaPower
commented
- Adding a new precompile can cause a divergence, even if it doesn't have any methods. Therefore, this PR keeps track of the number of methods + the number of precompiles added in every ArbOS version.
- Debug precompiles' methods aren't visible for production chains, so they should be ignored for this test. It should be fine to retroactively add new methods to them (though adding new debug precompiles altogether would still cause a divergence I think).
cla-bot
bot
added
the
s
PlasmaPower
added
testing
tsahee
requested changes
Nov 7, 2024
| for _, method := range precompile.Precompile().methods { | ||
| version := arbmath.MaxInt(method.arbosVersion, precompile.Precompile().arbosVersion) | ||
| innerPrecompile := precompile.Precompile() | ||
| newMethodsPerArbosVersion[innerPrecompile.arbosVersion]++ |
There was a problem hiding this comment.
add a comment explaining it and/or rename newMethodsper.. to newEntriesPer..
|
|
| 5: 3, | ||
| 10: 2, | ||
| 11: 4, | ||
| 20: 8, | ||
| 30: 38, | ||
| 30: 39, | ||
| 31: 1, | ||
| } | ||
|
|
||
| precompiles := Precompiles() | ||
| newMethodsPerArbosVersion := make(map[uint64]int) |
There was a problem hiding this comment.
Suggested change
| newMethodsPerArbosVersion := make(map[uint64]int) | |
| // Number of precompile methods per ArbOS version | |
| newMethodsPerArbosVersion := make(map[uint64]int) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.