Improve the BOLD Challenge Cache #2459
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cla-bot
bot
added
the
s
tsahee
requested changes
Jul 10, 2024
| } | ||
| t.Run("pruning non-existent dirs does nothing", func(t *testing.T) { | ||
| if err = cache.Prune(ctx, key.MessageHeight); err != nil { | ||
| t.Error(err) |
There was a problem hiding this comment.
is it t.Error and not t.Fatal on urpose? (It's probably o.k. either way.. just making sure)
There was a problem hiding this comment.
Yes, so that it does not stop other runs
|
Ready again @tsahee |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR improves the BOLD challenge cache with feedback from @tsahee on https://github.com/OffchainLabs/nitro/pull/2391/files. It contains the following improvements:
Init()method to the cache such thatNewhas no side-effectstempdir inside of the base dir on cacheInit(). All temporary writes when putting to the cache will be made to temp files in this directory. This means when wePut(), we can just doos.CreateTempwithin that dir. Once the writing completes, we do an atomicos.Renameof that file from the temp dir to the actual path it needs to live in