feat: show token tooltip in transfer summary #2202
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
brtkx
commented
Jan 22, 2025
| @@ -20,7 +20,7 @@ import { useTokensFromLists, useTokensFromUser } from './TokenSearchUtils' | |||
|
|
|||
| export type TokenButtonOptions = { | |||
| symbol?: string | |||
| logoSrc?: string | |||
| logoSrc?: string | null | |||
There was a problem hiding this comment.
null is used if we want to show native currency, otherwise selected token is show as the token logo
brtkx
commented
Jan 22, 2025
There was a problem hiding this comment.
This file hasn't been used anywhere at all
brtkx
commented
Jan 23, 2025
packages/arb-token-bridge-ui/src/components/TransferPanel/TokenInfoTooltip.tsx
Outdated
Show resolved
Hide resolved
fionnachan
reviewed
Jan 24, 2025
packages/arb-token-bridge-ui/src/components/TransferPanel/TokenInfoTooltip.tsx
Outdated
Show resolved
Hide resolved
packages/arb-token-bridge-ui/src/components/TransferPanel/TokenInfoTooltip.tsx
Show resolved
Hide resolved
packages/arb-token-bridge-ui/src/components/TransferPanel/TokenInfoTooltip.tsx
Outdated
Show resolved
Hide resolved
packages/arb-token-bridge-ui/src/components/TransferPanel/TokenInfoTooltip.tsx
Outdated
Show resolved
Hide resolved
fionnachan
approved these changes
Jan 30, 2025
Comment on lines
301
to
+307
| return token?.isL2Native ? ( | ||
| <BlockExplorerTokenLink chain={childChain} address={token.address} /> | ||
| <BlockExplorerTokenLink chainId={childChain.id} address={token.address} /> | ||
| ) : ( | ||
| <BlockExplorerTokenLink chain={parentChain} address={token.address} /> | ||
| <BlockExplorerTokenLink | ||
| chainId={parentChain.id} | ||
| address={token.address} | ||
| /> |
There was a problem hiding this comment.
nit: you can simplify this to
<BlockExplorerTokenLink
chainId={
token?.isL2Native
? networks.destinationChain.id
: networks.sourceChain.id
}
address={token.address}
/>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.