Add mod status in comment.list response #158
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
do we need any db caching for this, or we think it will be performant enough? |
nikooo777
force-pushed
the
mod-status-to-comment-list
branch
from
55d7d6b to
173b384
Compare
|
So, I took a deeper look at this, it's problematic because it doesn't use a cache, which would cause quite a load on the database. |
keikari
force-pushed
the
mod-status-to-comment-list
branch
from
77f171b to
8e8ee20
Compare
|
Wasn't sure what numbers use to the ccache. Current setting maxItems: 100000 and expirationTime: 10mins |
|
@nikooo777 no rush, but would ne nice to get this in. |
nikooo777
force-pushed
the
mod-status-to-comment-list
branch
from
8e8ee20 to
3e0b182
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.