fixed len_output method does not support handler-defined logic issue #26
+18
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zeddo123
requested changes
Jan 26, 2025
There was a problem hiding this comment.
Thank you @koussayinsat12 for your contribution! There's a single think to take care of and then we'll merge this PR.
octopipes/workflow.py
Outdated
| handler = self.workflow.handlers[output] | ||
| output = self.outputs[output] | ||
|
|
||
| return handler.len_output(output) if hasattr(output, '__len__') else None |
There was a problem hiding this comment.
I don't think the if statement is necessary anymore since the handler would take care of any underlying logic.
There was a problem hiding this comment.
I used the statement if, because the DefaultHandler returns len of the output and when the output is not the type of variable that we can't calculate its length, it returns None. If we remove the if statement, the tests of the workflow will fail
There was a problem hiding this comment.
I have deleted the if statement inside the workflow and integrate it inside the handlers
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request refactors the len_output method in the workflow implementation to address inconsistencies in how output lengths are calculated. Previously, the method directly computed the length of self.current_output, ignoring handler-defined logic. This caused issues when custom handlers redefined the logic for determining output length.
The updated implementation now leverages the corresponding handler to calculate the length of the output, ensuring consistency across workflows.
Key Changes:
1.Delegation to Handlers:
2.Flexible Output Selection:
3.Improved Readability and Maintenance: