Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

len_output Method Does Not Use Handler-Defined Logic #25

Closed
koussayinsat12 opened this issue Jan 24, 2025 · 1 comment · Fixed by #26
Closed

len_output Method Does Not Use Handler-Defined Logic #25

koussayinsat12 opened this issue Jan 24, 2025 · 1 comment · Fixed by #26
Labels
enhancement New feature or request

Comments

@koussayinsat12
Copy link
Contributor

koussayinsat12 commented Jan 24, 2025

The len_output method in the workflow implementation does not utilize handler-defined logic for calculating the length of the output, as seen in methods like json_output. Instead, it directly calculates the length of the current_output attribute, which causes inconsistencies when the handler is designed to redefine how the output length should be computed.

@zeddo123
Copy link
Member

zeddo123 commented Jan 24, 2025

Yeah I see what you mean. Although the len_output function in the workflowIter class was not acuatlly made to use the handler (I usually use the handler's method directly), I think that calling the handler in this case would provide a much better API.

@zeddo123 zeddo123 added the enhancement New feature or request label Jan 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants