Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

*: support electra in existing codebase; tests #3487

Merged
merged 2 commits into from
Jan 31, 2025

Conversation

KaloyanTanev
Copy link
Collaborator

On first look it seems like a big PR, but it consists of 2 main things:

  1. Adding electra version support to all switch cases throughout the codebase.
  2. Adding tests for electra + improving the test coverage of already existing versions.

category: feature
ticket: none

@KaloyanTanev KaloyanTanev requested a review from pinebit January 30, 2025 13:30
@github-actions github-actions bot added the electra PR targeting electra upgrade label Jan 30, 2025
@KaloyanTanev KaloyanTanev self-assigned this Jan 30, 2025
Copy link

codecov bot commented Jan 30, 2025

Codecov Report

Attention: Patch coverage is 96.96970% with 2 lines in your changes missing coverage. Please review.

Please upload report for BASE (electra@af7658f). Learn more about missing BASE report.

Files with missing lines Patch % Lines
app/eth2wrap/synthproposer.go 83.33% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             electra    #3487   +/-   ##
==========================================
  Coverage           ?   57.27%           
==========================================
  Files              ?      218           
  Lines              ?    33702           
  Branches           ?        0           
==========================================
  Hits               ?    19304           
  Misses             ?    12387           
  Partials           ?     2011           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@KaloyanTanev KaloyanTanev merged commit 6b029b5 into electra Jan 31, 2025
10 of 11 checks passed
@KaloyanTanev KaloyanTanev deleted the kalo/electra-support-existing-codebase branch January 31, 2025 10:50
KaloyanTanev added a commit that referenced this pull request Jan 31, 2025
* Add electra version support in all switch cases

* Add more electra tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
electra PR targeting electra upgrade
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants