app/eth2wrap: add CLI support for fallback beacon node #3459
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DiogoSantoss
requested review from
gsora,
pinebit and
KaloyanTanev
and removed request for
gsora and
pinebit
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3459 +/- ##
==========================================
+ Coverage 57.05% 57.40% +0.35%
==========================================
Files 218 217 -1
Lines 32634 32249 -385
==========================================
- Hits 18618 18513 -105
+ Misses 12105 11824 -281
- Partials 1911 1912 +1 ☔ View full report in Codecov by Sentry. |
pinebit
approved these changes
Jan 16, 2025
DiogoSantoss
force-pushed
the
diogo/fallback-beacon-node
branch
from
3f8d183 to
fe366ec
Compare
DiogoSantoss
force-pushed
the
diogo/fallback-beacon-node
branch
from
ebd1e42 to
f780477
Compare
KaloyanTanev
approved these changes
Jan 22, 2025
|
DiogoSantoss
added
the
merge when ready
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
--fallback-beacon-node-endpointsCLI flag to specify a list of beacon nodes to use if the primary list (specified using--beacon-node-endpoints) fails.This is the continuation of a previous PR (#3342) which added the fallback logic.
category: feature
ticket: #3328