eth2util: new deposit message with amount #2822
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2822 +/- ##
==========================================
+ Coverage 53.14% 53.21% +0.07%
==========================================
Files 200 200
Lines 27705 27711 +6
==========================================
+ Hits 14723 14746 +23
+ Misses 11151 11132 -19
- Partials 1831 1833 +2 ☔ View full report in Codecov by Sentry. |
xenowits
reviewed
Jan 25, 2024
xenowits
reviewed
Jan 25, 2024
|
gsora
approved these changes
Jan 29, 2024
dB2510
approved these changes
Jan 29, 2024
Comment on lines
+22
to
+27
| // Minimum allowed deposit amount (1ETH). | ||
| MinValidatorAmount = eth2p0.Gwei(1000000000) | ||
|
|
||
| // Maximum allowed deposit amount (32ETH). | ||
| MaxValidatorAmount = eth2p0.Gwei(32000000000) | ||
|
|
There was a problem hiding this comment.
Will need to update here after merging #2820
pinebit
added
the
merge when ready
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NewMessagefunction that createsDepositMessageto receive custom amount. Was 32ETH by default.category: feature
ticket: none