core: fixing DutyDB Store function #2800
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2800 +/- ##
==========================================
+ Coverage 53.21% 53.28% +0.06%
==========================================
Files 199 199
Lines 27616 27616
==========================================
+ Hits 14696 14715 +19
+ Misses 11097 11081 -16
+ Partials 1823 1820 -3 ☔ View full report in Codecov by Sentry. |
dB2510
approved these changes
Jan 18, 2024
xenowits
approved these changes
Jan 19, 2024
pinebit
added
the
merge when ready
gsora
pushed a commit
that referenced
this pull request
Jan 24, 2024
DutyDB's `Store()` function has inconsistent handling for `DutySyncContribution`. category: bug ticket: none
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DutyDB's
Store()function has inconsistent handling forDutySyncContribution.category: bug
ticket: none