Add dark mode to documentation #58
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…added them. Also added dark mode to documentation. If i am going to work on it i really need dark mode :'D
ObaraEmmanuel
requested changes
Jan 17, 2025
docs/requirements.txt
Outdated
| sphinx-rtd-theme==3.0.2 | ||
| pillow==11.0.0 | ||
| python-tkdnd==0.2.0 |
There was a problem hiding this comment.
Thank you for taking interest in the project. These two modules (pillow and python-tkdnd) are not required for the documentation build process and should not be included here.
There was a problem hiding this comment.
My bad, i saw missing dependency errors after running make html, so i thought they were a necessity
WARNING: autodoc: failed to import module 'loader' from module 'formation'; the following exception was raised:
No module named 'PIL' [autodoc.import_object]
WARNING: autodoc: failed to import module 'utils' from module 'formation'; the following exception was raised:
No module named 'PIL' [autodoc.import_object]
WARNING: autodoc: failed to import module 'dialogs' from module 'hoverset.ui'; the following exception was raised:
No module named 'tkinterDnD' [autodoc.import_object]
WARNING: autodoc: failed to import module 'widgets' from module 'hoverset.ui'; the following exception was raised:
No module named 'tkinterDnD' [autodoc.import_object]
WARNING: autodoc: failed to import module 'ui.geometry' from module 'studio'; the following exception was raised:
No module named 'PIL' [autodoc.import_object]
I will change it now.
There was a problem hiding this comment.
I see. Ideally you should have installed the main dependencies of the project which are specified in the root requirements.txt for autodoc to work.
ObaraEmmanuel
changed the title
|
I have forgot to commit .gitignore so i did that too. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There were following modules missing;
Also i wanted to add dark mode. There were no change on the initial theme. I have found a dark mode for the exact same theme!
sphinx-rtd-dark-mode
And added
docs/_buildto .gitignore since we do not want builds on repo.
I really liked your project btw. 😃